fix: remove raise inside except in gguf_inference#130
Open
Bindkushal wants to merge 1 commit intosugarlabs:mainfrom
Open
fix: remove raise inside except in gguf_inference#130Bindkushal wants to merge 1 commit intosugarlabs:mainfrom
Bindkushal wants to merge 1 commit intosugarlabs:mainfrom
Conversation
try/except was supposed to degrade gracefully when llama-cpp-python isn't installed. but the raise inside except just re-threw the error and crashed the whole activity on startup, even if you only wanted TTS. removed the raise. GGUF_AVAILABLE = False does the job.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The except ImportError block sets GGUF_AVAILABLE = False to signal graceful degradation,, that was nice exception handling block but then immediately raises the same exception — making the flag pointless. Any code that checks GGUF_AVAILABLE never gets a chance to run because the activity crashes first. Removing the raise lets the flag do its job — TTS works normally and LLM is simply disabled when llama-cpp-python is not installed. and (llma-cpp-python needs whole c compiler or precompiled weheel, to protect the crash)
Test Video Link
https://drive.google.com/file/d/1MWZA1dKCkh0B5uCK3pYlXkdRjPfhBD0n/view?usp=sharing