-
Notifications
You must be signed in to change notification settings - Fork 43
feat: improve rag responses with better prompt and gen params. #23
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
Khan-Ramsha
wants to merge
13
commits into
sugarlabs:main
Choose a base branch
from
Khan-Ramsha:improve-rag-response
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from 1 commit
Commits
Show all changes
13 commits
Select commit
Hold shift + click to select a range
0652404
feat: improve rag responses with better prompt, gen params, and child…
Khan-Ramsha 684a604
refactor: improving code readability
Khan-Ramsha e7bc03a
chore: remove unused Qwen model from CLI options
Khan-Ramsha 9053d59
chore: increasing token value
Khan-Ramsha c0bb209
chore: add missing newline at end of file
Khan-Ramsha 7fd33c6
chore(debug): add debug print for retrieved documents
Khan-Ramsha 415cac4
Simplify model pipeline by removing redundant generation parameters
Khan-Ramsha 396edd4
Modified get_relevant_document() and run() to improve context passing
Khan-Ramsha ed2c83a
chore: remove unnecessary comma after last model choice in argparse
Khan-Ramsha c394eb8
prompt: tweak child-friendly prompt and add temperature for model con…
Khan-Ramsha 03132cb
chore: add debug prints for final response, prompt, first response, a…
Khan-Ramsha 2f8c373
remove restriction for document-based answer.
Khan-Ramsha 8061058
remove debug prints
Khan-Ramsha File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not all answers are supposed to be in the documents, the documents are there for Sugar specific context not as the sole source of answers.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Totally agree the model should still answer even if there's no doc context. That was a temp check I forgot to remove. Will fix it