Open
Conversation
Prior to this fix, the application bypassed quota incrementation for brand new API key requests. This assigns the dictionary and allows it to fall through to the proper count increment logic.
There was a problem hiding this comment.
Pull request overview
Fixes an API quota accounting bug where a brand-new API key’s first request was not being counted, causing the UI and quota enforcement to show an incorrect remaining quota after the first successful request.
Changes:
- Removed the early return in
check_quota()for new API keys so first use properly increments the request count. - Ensured newly seen API keys initialize quota tracking and then fall through to the shared increment/limit logic.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Prior to this fix, the application bypassed quota incrementation for brand new API key requests. When a new API key was used, it returned
Trueimmediately without falling through to the proper count increment logic. This essentially gave new users an extra uncounted API request on their first use.This fix removes the early return for new keys, initializes the quota tracking dictionary properly, and allows the execution to smoothly fall through to the proper increment logic at the bottom of the function.
Screenshots
After Fixing