Update About Section UI and Fix Google Summer of Code Link #643
Conversation
It looks fine on my machine.
|
|
Yeah I reloaded this section was fine.
|
|
i have reviewed this PR and tested, it is good to merge after extra line at EOF is removed. |
The additional line has been intentionally included as instructed earlier by @quozl . |
|
@uditjainstjis please explain why you would want the last newline of a file removed? It is our convention to end files with newlines unless the file comes from an upstream which does not. Missing newlines disrupts shell prompt after |
|
sorry, i misunderstood earlier, looks good to merge. |
|
@Devmoni can you please resolve the conflict rq? Thanks! Otherwise, it looks much better. |
about-us.html
Outdated
| <div class="project-card"> | ||
| <h4>Sugar on a Stick</h4> | ||
| <p>A portable version of Sugar that can run from a USB stick without installation.</p> | ||
| <a href="https://wiki.sugarlabs.org/go/Sugar_on_a_Stick"> |
There was a problem hiding this comment.
We should link https://www.sugarlabs.org/booting-soas/ instead.
| </div> | ||
| <div class="col-sm-6 col-md-6 mb-4"> | ||
| <div class="project-card"> | ||
| <h4>Math4 Project</h4> |
There was a problem hiding this comment.
I have no sense of whether or not this project is still alive.
It may be good to comment this part out for now...
| <div class="project-card"> | ||
| <h4>Sugar Creation Kit</h4> | ||
| <p>A toolkit to help users create engaging and interactive content for the Sugar environment.</p> | ||
| <a href="https://wiki.sugarlabs.org/go/Sugar_Creation_Kit"> |
There was a problem hiding this comment.
These instructions need to be updated, so I'd comment this section out for now.
Devmoni
force-pushed
the
about
branch
2 times, most recently
from
9cf912a to
d2a3917
Compare
- Made minor UI adjustments to improve the design of the About section. - Replaced the existing Google Summer of Code link with the direct GitHub link to eliminate the unnecessary redirection.
|
I have resolved the conflicts and made the requested changes. |
|
I'm going to review once again tomorrow, but, after a quick look, I think it should be something like "highlighted projects". As we have many more projects than these two, so that section could be a bit misleading as just "Projects". |
|
Okay, |
Yes, but we can do that separately. |
Changes:
Reason: