📱(react) do not hide subtitle modal tab on small viewport#394
Open
jbpenrath wants to merge 1 commit into
Open
Conversation
NathanVss
reviewed
Jun 22, 2026
| } | ||
|
|
||
| &__header { | ||
| margin-bottom: var(--c--globals--spacings--2xs); |
Collaborator
There was a problem hiding this comment.
By doing so you add a margin even when there is no subtitle, is it expected?
Collaborator
Author
There was a problem hiding this comment.
Nope good catch. I applied a margin-top on the subtitle instead.
Currently, the tab subtitle is hidden in modal tab on small viewports.
jbpenrath
force-pushed
the
fix/subtitle-modal-tab-mobile
branch
from
53ef03b to
7077684
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently, the tab subtitle is hidden in modal tab on small viewports.