♿(frontend) localize LaGaufre label fallback in Docs#1979
Open
♿(frontend) localize LaGaufre label fallback in Docs#1979
Conversation
Ovgodd
force-pushed
the
fix/frontend-waffle-label-i18n
branch
from
adbbaa3 to
7c6444a
Compare
|
Size Change: +168 B (0%) Total Size: 4.25 MB
|
We pass a translated fallback label so the waffle follows the app locale.
Ovgodd
force-pushed
the
fix/frontend-waffle-label-i18n
branch
from
7c6444a to
5bb5dda
Compare
AntoLC
reviewed
Mar 11, 2026
src/frontend/apps/impress/src/features/header/components/Waffle.tsx
Outdated
Show resolved
Hide resolved
Ovgodd
force-pushed
the
fix/frontend-waffle-label-i18n
branch
from
2969eda to
92286fd
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
Fix LaGaufre (waffle) label localization in Docs. The label stayed in English regardless of the selected language because Docs uses
CunninghamProviderinstead of the ui-kit provider, soLaGaufreV2internal translations were not applied. We now pass an explicit, translated label from Docs i18n.1973
Proposal
label={t('LaSuite digital services')}inWaffle.tsxwhenwaffleConfig.labelis not providedtranslations.json(en, fr, de, es)