🔒️(yprovider) readOnly connections awareness propagation - #2544
Open
AntoLC wants to merge 1 commit into
Open
Conversation
AntoLC
force-pushed
the
secu/block-awareness-when-reader
branch
from
July 29, 2026 12:10
e9a9fdf to
d13c89a
Compare
We noticed that a read-only connection was still able to propagate awareness updates (cursor/selection presence) to other clients, even though connectionConfig.readOnly already blocked document sync updates. Override MessageReceiver.apply to no-op for any read-only connection instead of delegating to the original implementation, so document awareness updates never propagate from it. The connection itself is left open; only the awareness is dropped.
AntoLC
force-pushed
the
secu/block-awareness-when-reader
branch
from
July 29, 2026 12:45
d13c89a to
487411f
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
We noticed that a read-only connection was still able to propagate awareness updates (cursor/selection presence) to other clients, even though
connectionConfig.readOnlyalready blocked document sync updates.Override
MessageReceiver.applyto no-op for any read-only connection instead of delegating to the original implementation, so neither document updates nor awareness updates ever propagate from it.The connection itself is left open; only the message is dropped.