Skip to content

Conversation

@Uncle-Lester
Copy link

👋 Hey!

This is my first time contributing on GitHub and also my first PHP/Laravel project, so thank you in advance for your patience.

I’ve attempted to implement mobile and tablet responsiveness for Kabus v1.0 using mostly CSS. I also tried to restore the original branding and colours as accurately as I could — though I’m aware it may not be perfect.

I’m not entirely sure if I’ve included everything required to make this a perfect submission, but I’m happy to send over my full project files if it helps with testing or review.

I hope this can be helpful for future releases or at least serve as a reference. I’d love to connect and possibly discuss a few feature ideas I had in mind as well. I'm still learning, but really interested in contributing further to the project if you'll have me.

Thanks again for all your work on Kabus — it’s been a great learning experience already 🙏

Modified views to support mobile/tablet layout.
Custom stylesheet for mobile-first layout. No impact to desktop UI.
@sukunetsiz
Copy link
Owner

Great! Thank you for your contribution. However, there is one thing you need to change before I can merge this. We do not use any JavaScript in our marketplace at all. None. You need to find a workaround for the hamburger button. It must be implemented purely with CSS. You could try using the :checked pseudo-class with a hidden checkbox input, or something similar.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants