Skip to content

Conversation

@jcoyne
Copy link
Contributor

@jcoyne jcoyne commented Jul 15, 2025

Interfacing with external services like solr ought to be done in the controller rather than in the view

@jcoyne jcoyne force-pushed the collection-load branch 3 times, most recently from cffd53e to 95c335d Compare July 15, 2025 18:34
@jcoyne jcoyne marked this pull request as ready for review July 15, 2025 18:35
@jcoyne jcoyne force-pushed the collection-load branch from 95c335d to 6b71365 Compare July 16, 2025 05:01
Interfacing with external services like solr ought to be done in the controller rather than in the view
@jcoyne jcoyne force-pushed the collection-load branch from 6b71365 to b30932f Compare July 17, 2025 16:12
@marlo-longley
Copy link
Contributor

marlo-longley commented Jul 17, 2025

Does this PR have implications for how other components are loading page_location ? They should continue to load as a helper as in:

delegate :page_location, :search_state, :add_filter_unless_present, :remove_filter_if_present, to: :helpers

helpers.page_location.collection? && collection.present?

@jcoyne
Copy link
Contributor Author

jcoyne commented Jul 18, 2025

@marlo-longley no, I don't think anything is changed about it. Its still in the helper context.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants