[HOLD] add provenance convenience column to pub table table #1458
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
peetucket
changed the title
peetucket
force-pushed
the
add-provenance
branch
3 times, most recently
from
69add7f to
f726205
Compare
jmartin-sul
approved these changes
Mar 18, 2022
Member
jmartin-sul
left a comment
jmartin-sul
left a comment
There was a problem hiding this comment.
one nitpick, but wouldn't hold up merging over it
peetucket
force-pushed
the
add-provenance
branch
from
b5f2440 to
0488356
Compare
peetucket
force-pushed
the
add-provenance
branch
from
0488356 to
a374e1d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why was this change made?
Fixes #652 - this will make it easier to run some analysis queries about where publications originally came from without resorting to identifiers or inspecting the pub_hash. Note that this change will need a migration to the database, adding a column and an index to a big table, so may want to do off hours in case it takes a while.
Hold for now so we can plan this for a good time.
we will then want to run the rake task to back-fill data
How was this change tested?
Localhost
Which documentation and/or configurations were updated?