Add Brevo types/config and deprecate usage of Sendinblue

[gruberro]

Q	A
Bug fix?	no
New feature?	no
BC breaks?	yes
Deprecations?	yes
Fixed tickets	fixes #384
Related issues/PRs	❌
License	MIT

What's in this PR?

This PR aims to replace the deprecated naming/package SendinBlue with Brevo.

Why?

Get rid of deprecation warnings and keep naming aligned with official third-party naming.

BC Breaks/Deprecations

Configuration field sendinblue_api_key is renamed to brevo_api_key. Also all internal fields are renamed. This for sure requires existing form configurations to be updated. Not sure how you would like to proceed with that kind of changes. LMK if you desire another way of refactoring.

[alexander-schranz]

@gruberro Thank you for your contribution. This currently would be a bc break so I will keep this open for the next major release so we can merge it then.

[alexander-schranz]

I think the best option without a bc break would be to add new config and a new type with called brevo and provide documentation how to migrate from sendinblue configuration to brevo. Then we can keep this 2 types and remove in 3.0 the sendinblue type. The new type can then already use the new sdk.

@steeven-th @gruberro what do you think?

[steeven-th]

Sendinblue has become Brevo.
If the Sendinblue API still works, it's a good idea to keep it until version 3.0.
But if it's no longer working, it's better to remove it.

[gruberro]

Sounds absolut valid. Sendinblue package is abandoned, but is still working. Do you want me to rework this PR @alexander-schranz?

[alexander-schranz]

If you want to work on it 👍 . In the config it will be something like:

-    ->scalarNode('sendinblue_api_key')->defaultValue(null)->end()
+    ->scalarNode('sendinblue_api_key')->setDeprecated(/*...*/)->defaultValue(null)->end()
+    ->scalarNode('brevo_api_key')->defaultValue(null)->end()

And then keep the sendinblue part as it is and create the new brevo files. We can then add a line to the UPGRADE.md how to change from the sendinblue to brevo sdk. So people can start new projects or migrate projects already to brevo and don't get a composer deprecation message if they alread did it.

[gruberro]

Ok, will take care of over the next days…

[gruberro]

@alexander-schranz I've reworked the PR by adding Brevo and deprecating all Sendinblue thingies 😄

[alexander-schranz]

@gruberro Can you also add a description in the UPGRADE.md how to switch from SendinBlue to Brevo including SQL update query for existing form with sending blue.

[gruberro]

@gruberro Can you also add a description in the UPGRADE.md how to switch from SendinBlue to Brevo including SQL update query for existing form with sending blue.

@alexander-schranz I've done that, but I would really appreciate a review of the query since I don't have a good knowledge of Sulu Forms' data management. I guess the form field id should remain as it is?

[gruberro]

tbd