Add Sulu 3.0 compatibility #416
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Changed FormFieldTypePool and TitleProviderPool constructors to accept iterable instead of array, enabling Symfony's tagged_iterator injection.
The TaggedServiceCollectorCompilerPass was removed in Sulu 3.0. Service collection is now handled by Symfony's native tagged_iterator.
- PropertiesXmlLoader: Use AdminBundle's AbstractLoader and PropertiesXmlParser - DynamicFormMetadataLoader: Remove FormMetadataMapper dependency (removed in Sulu 3.0), add locales parameter, update to locale-independent caching
- Use tagged_iterator for pool services - Update service references (sulu_page.* -> sulu_admin.*) - Add locales parameter to DynamicFormMetadataLoader - Remove FormWebsiteController service registration
The controller extended DefaultController which was removed in Sulu 3.0. Static forms are deprecated and should not be used.
- Add SingleFormSelectionPropertyResolver with resourceCallback for entity + serialized data - Add FormResourceLoader for batch loading forms by ID - Add FormRepository::loadByIds method - Add sulu_form_build Twig function for render-time form building - Remove old SingleFormSelection content type - Add UPGRADE-3.0.md with migration guide - Rename UPGRADE.md to UPGRADE-2.x.md
…eTitleProvider - Replace isMasterRequest() with isMainRequest() in event listeners - Replace getMasterRequest() with getMainRequest() in StructureTitleProvider - Refactor StructureTitleProvider to use DimensionContentInterface instead of removed StructureInterface - Update UPGRADE-3.0.md with migration notes
- Replace ListRepresentation with PaginatedRepresentation - Fix DateTime vs DateTimeImmutable type errors - Remove ClassResourceInterface from controllers (removed in FOS REST 3.0) - Use Request::query->getString() instead of Request::get() with is_string checks - Fix type annotations and assertions across multiple files - Regenerate PHPStan baseline
mamazu
reviewed
Dec 11, 2025
| $this->assertEquals('attachment', $fields->getDefaultType()); | ||
| $this->assertEquals([ | ||
| $this->assertEquals('text', $fields->getDefaultType()); | ||
| $this->assertEqualsCanonicalizing([ |
Contributor
There was a problem hiding this comment.
This is a good point, how does 2.6 sort their State fields? Now they're no longer sorted the same way. We could just register the FormTypes with a priority attribute now to force a sorting.
mamazu
reviewed
Dec 11, 2025
mamazu
approved these changes
Dec 11, 2025
- Remove PHP 7.2, 7.4, 8.0, 8.1 (incompatible with Sulu 3.0 requirement of PHP ^8.2) - Add PHP 8.2 with lowest dependencies test - Add PHP 8.5 with dev stability for future compatibility - Update MySQL from 5.7 to 8.0 - Update PostgreSQL from 12.5 to 14 - Remove phpunit-9.xml.dist (PHPUnit 10/11 only now) - Update all database serverVersion parameters
Co-authored-by: mamazu <[email protected]>
mamazu
reviewed
Dec 11, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's in this PR?
Adds support for Sulu 3.0
To Do