Update property types about articles#891
Conversation
martinlagler
force-pushed
the
feature/article-property-types
branch
2 times, most recently
from
aa06fa8 to
249a8db
Compare
| <param name="excerptDescription" value="excerpt.description"/> | ||
| <param name="uuid" value="object.resource.id"/> | ||
| </param> | ||
| <param name="item_disabled_condition" value="title == 'No'"/> |
There was a problem hiding this comment.
provide always a simple example first which shows the basic usecase. And only uncommon things like object.resource and item_disabled_conditoin mapping to a own Complex Example under own headline.
As the first example is mostly the one which is copied to projects and it should not contain things which are not very common.
There was a problem hiding this comment.
Pull request overview
Updates the property-type documentation to cover article-related selections and SmartContent usage for Sulu 3.x, including new reference pages for article selection types.
Changes:
- Added documentation for
article_selectionandsingle_article_selectionproperty types. - Extended SmartContent provider docs with an
articlesprovider section. - Updated existing selection docs/examples (
page_selection,single_page_selection) and expanded their parameter descriptions.
Reviewed changes
Copilot reviewed 6 out of 6 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
| reference/property-types/smart_content.rst | Adds an Articles SmartContentProvider section with alias and parameters. |
| reference/property-types/single_page_selection.rst | Updates description/parameters and replaces Twig guidance with populated template fields usage. |
| reference/property-types/single_article_selection.rst | New doc page describing the single article selection property type, params, and Twig usage. |
| reference/property-types/page_selection.rst | Updates example to use pages naming and adds uuid + item_disabled_condition params. |
| reference/property-types/index.rst | Adds article_selection and single_article_selection to the toctree. |
| reference/property-types/article_selection.rst | New doc page describing the article selection property type, params, and Twig usage. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
|
|
||
| Shows a field, on which exactly one link to another page can be assigned. | ||
| Additionally it populates all the fields defined in the template configuration | ||
| to the HTML template. The content is stored as an array of references. |
There was a problem hiding this comment.
The description says the content is "stored as an array of references", but the property is described as selecting exactly one page and the Twig example treats content.page as a single object (e.g., content.page.url). Please clarify the actual return/storage format and make the description consistent with the example.
| to the HTML template. The content is stored as an array of references. | |
| to the HTML template. The selected page is exposed to the HTML template as a single object containing the configured properties. |
martinlagler
force-pushed
the
feature/article-property-types
branch
from
249a8db to
6cb0aed
Compare
martinlagler
force-pushed
the
feature/article-property-types
branch
from
6cb0aed to
fb68ba7
Compare
What's in this PR?
Update property types for articles for Sulu 3.x