Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Updates the documentation for building Sulu’s admin frontend to reflect newer Node/npm tooling expectations.
Changes:
- Updates the Docker-based manual build example to use a newer Node image tag.
- Updates the “supported Node.js and npm version” guidance and the warning for older Sulu versions.
- Removes the old reference link to the npm v7 compatibility issue.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
cookbook/build-admin-frontend.rst
Outdated
Comment on lines
+37
to
+38
| # for Versions before 2.6 npm 6 has to be used so Node 14 is best there: | ||
| # docker run --rm --interactive --tty --volume ${PWD}:/var/project node:14.16.0 /bin/bash |
There was a problem hiding this comment.
This comment reads awkwardly and has inconsistent capitalization (“for Versions…”, “best there”). Please rephrase to be grammatically correct and clearer about the constraint (e.g., that Sulu < 2.6 needs npm 6 / Node 14).
Prokyonn
reviewed
Feb 24, 2026
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What's in this PR?
Upgrade node versions.
Why?
Use newer node versions in docs.