Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add nl_NL translations for Plunder expansion #537

Conversation

siblingsofthevoid
Copy link
Contributor

Help, I think i just lost my sanity...

In all seriousness, these are all card descriptions and extras as per Dutch cards and manual.
In basically all cases i tried to preserve the order as it is in the en_US translations.

@sumpfork sumpfork self-requested a review September 30, 2024 18:01
@sumpfork
Copy link
Owner

Thanks! Can you install pre-commit and run pre-commit install and pre-commit run --all-files locally? Otherwise I'll try to find time to do it.

@siblingsofthevoid
Copy link
Contributor Author

Yeah, can do that. I'll probably do it now, if that seems to not have happened, It'll be there in the evening ^^

@sumpfork
Copy link
Owner

sumpfork commented Oct 1, 2024

Seems to have some missing tags now: paragraph text '<para>Handel de geldkaartaf voordat je Landingstroepen op je trekstapel legt. Het is ok\xe9 als de geldkaart meerdere soorten heeft, inclusief Actie (zoals Toverrol).<br /><i><b>Voorbeeld:<b> is de geldkaart een Beeldje dan trek je 2 kaarten voordat je Landingstroepen op je Trekstapel legt.<i></para>' caused exception Parse error: saw </para> instead of expected </i>

@siblingsofthevoid
Copy link
Contributor Author

OH
that may actually be a typo on my side. Seems i missed one.
I'll do another full check for typos and unclosed tags ^^

@siblingsofthevoid
Copy link
Contributor Author

siblingsofthevoid commented Oct 1, 2024

Okay, I just did a pass over the entire diff and fixed as many typos and unclosed tags as i could find.

@sumpfork
Copy link
Owner

sumpfork commented Oct 1, 2024

Remember you can run tests locally via doit test or pip install -e .[dev] and then pytest. Or, tox works too if you have that installed.

You'll also need to recompile the gzs and mark the conflict as resolved.

@siblingsofthevoid
Copy link
Contributor Author

You'll also need to recompile the gzs and mark the conflict as resolved.

Ah yes, forgive me, it's been a while since I've done dev stuff xD

@siblingsofthevoid
Copy link
Contributor Author

Okay, I rebased on the latest master, I recompiled the card DB one last time (merged into 24795fe since i was rebasing anyway) and i ran the tests locally. Pytest does not seem to be complaining.

A note on marking the conflicts as resolved: I don't have write access to this repo, so i cannot mark conflicts as resolved ^^
The Card DB is in the latest state it could possibly be tho, so it should be fine.

@sumpfork
Copy link
Owner

sumpfork commented Oct 1, 2024

Replaced by #541

@sumpfork sumpfork closed this Oct 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants