-
Notifications
You must be signed in to change notification settings - Fork 129
Remove deprecated icons #3744
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Remove deprecated icons #3744
Changes from 8 commits
Commits
Show all changes
10 commits
Select commit
Hold shift + click to select a range
153a807
delete deprecated icons
sirineJ 3ed71bf
rename flag files
sirineJ ae9a7df
replace deprecated icons internally
sirineJ 92a5621
refactor build file
sirineJ 98abeff
change icons eslint rule to error
sirineJ e67d1d2
lint
sirineJ a2905d3
add changeset
sirineJ 525d5db
keep deleted icons in manifest with inactive flag
sirineJ 7e9a573
Update .changeset/better-impalas-open.md
sirineJ e52f7fb
Update .changeset/fancy-weeks-dance.md
sirineJ File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
The table of contents is too big for display.
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,34 @@ | ||
| --- | ||
| "@sumup-oss/circuit-ui": major | ||
| --- | ||
|
|
||
| Removed the following deprecated icons: | ||
|
|
||
| | icon | replacement | | ||
| |-------------------|------------------------------------| | ||
| | AddItems | Add, Items | | ||
| | Copy | CopyPaste | | ||
| | SumUpLogo | SumupLogo (`sumup-oss/circuit-ui)` | | ||
| | SumUpLogomark | SumupLogo (`sumup-oss/circuit-ui) | | ||
| | Apm | AlternativePaymentMethod | | ||
| | EmailChat | Email | | ||
| | phone_chat | Phone | | ||
| | PhoneChat | Mobile | | ||
| | ColorCorrection | ColorPicker | | ||
| | CookiePreferences | Cookie | | ||
| | Customize | Customise | | ||
| | Favorite | Favourite | | ||
| | NoSim | NoSimcard | | ||
| | PrintFailed | PrinterFailed | | ||
| | Unfavorite | Unfavourite | | ||
| | Contractors | Contractor | | ||
| | notify_circle | Notify | | ||
| | general_settings | Settings | | ||
| | gift_card | GiftCards | | ||
| | payment_link | PaymentLinks | | ||
| | refer | ReferAFriend, Reward | | ||
| | sales | Receipt | | ||
| | messenger | FacebookMessenger | | ||
| | | ||
|
|
||
| Use the `no-deprecated-icons` to automatically apply the replacements. | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,5 @@ | ||
| --- | ||
| "@sumup-oss/icons": major | ||
| --- | ||
|
|
||
| Removed the deprecated Country Flag icons. Use the Flag component instead or load the icon with its URL using the [`getIconUrl()`](https://circuit.sumup.com/?path=/docs/packages-icons--docs#load-from-a-url) helper. | ||
|
sirineJ marked this conversation as resolved.
Outdated
|
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,5 @@ | ||
| --- | ||
| "@sumup-oss/icons": major | ||
| --- | ||
|
|
||
| Removed the deprecated Card Scheme icons. Use the new CardScheme component instead or load the icon with its URL using the [`getIconUrl()`](https://circuit.sumup.com/?path=/docs/packages-icons--docs#load-from-a-url) helper. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,5 @@ | ||
| --- | ||
| "@sumup-oss/icons": major | ||
| --- | ||
|
|
||
| Remove the deprecated Payment Method icons. Use the new PaymentMethod component instead or load the icon with its URL using the [`getIconUrl()`](https://circuit.sumup.com/?path=/docs/packages-icons--docs#load-from-a-url) helper. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Oops, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.