Skip to content

Include pharokka -> phold with plot#5

Open
Ulthran wants to merge 3 commits intomasterfrom
4-include-pharokka-and-phold-plot
Open

Include pharokka -> phold with plot#5
Ulthran wants to merge 3 commits intomasterfrom
4-include-pharokka-and-phold-plot

Conversation

@Ulthran
Copy link
Collaborator

@Ulthran Ulthran commented Jun 10, 2025

No description provided.

Copilot AI review requested due to automatic review settings June 10, 2025 18:30
@Ulthran Ulthran linked an issue Jun 10, 2025 that may be closed by this pull request
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR adds integration of Pharokka and Phold (with plotting) into the sbx_induceome workflow.

  • Replace standalone PHOLD GBK output with a plotted PNG in the all_induceome rule
  • Introduce install, annotation, and run rules for Pharokka and Phold, plus a new induceome_phold_plot rule
  • Update configuration (pharokka_db) and documentation (README badge and config entry)

Reviewed Changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.

File Description
sbx_induceome.smk Updated all_induceome to expect PNG outputs; added rules for installing Pharokka/Phold DBs, running Pharokka, and plotting Phold results
config.yml Added pharokka_db configuration key
README.md Fixed Tests badge URL and documented pharokka_db
Comments suppressed due to low confidence (5)

sbx_induceome.smk:67

  • The pipeline’s all_induceome rule no longer includes the Pharokka output, so the new induceome_pharokka step won’t run when invoking all. Consider adding an expand(INDUCEOME_FP / "pharokka" / "{sample}_pharokka.gbk", sample=SBX_INDUCEOME_SAMPLES) entry.
expand(INDUCEOME_FP / "phold" / "{sample}_plot" / "phold.png",

README.md:23

  • Typo: pharokka_dp should be pharokka_db to match the key in config.yml.
-  - pharokka_dp: Path to the pharokka db (full path to the directory that will hold db files)

sbx_induceome.smk:247

  • [nitpick] New induceome_pharokka rule is added but there are no tests covering this step. Consider adding tests to verify Pharokka annotation output.
rule induceome_pharokka:

sbx_induceome.smk:321

  • [nitpick] New induceome_phold_plot rule is introduced without corresponding tests. Adding a test to ensure plots are generated correctly would improve reliability.
rule induceome_phold_plot:

sbx_induceome.smk:224

  • [nitpick] The multiline path expression for output.pharokka is split across lines without parentheses, which may lead to syntax errors. Consider wrapping the entire expression in parentheses or placing it on a single line.
pharokka=Path(Cfg["sbx_induceome"]["pharokka_db"])

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Include pharokka and phold plot

2 participants