Open
Conversation
There was a problem hiding this comment.
Pull Request Overview
This PR adds integration of Pharokka and Phold (with plotting) into the sbx_induceome workflow.
- Replace standalone PHOLD GBK output with a plotted PNG in the
all_induceomerule - Introduce install, annotation, and run rules for Pharokka and Phold, plus a new
induceome_phold_plotrule - Update configuration (
pharokka_db) and documentation (README badge and config entry)
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| sbx_induceome.smk | Updated all_induceome to expect PNG outputs; added rules for installing Pharokka/Phold DBs, running Pharokka, and plotting Phold results |
| config.yml | Added pharokka_db configuration key |
| README.md | Fixed Tests badge URL and documented pharokka_db |
Comments suppressed due to low confidence (5)
sbx_induceome.smk:67
- The pipeline’s
all_induceomerule no longer includes the Pharokka output, so the newinduceome_pharokkastep won’t run when invokingall. Consider adding anexpand(INDUCEOME_FP / "pharokka" / "{sample}_pharokka.gbk", sample=SBX_INDUCEOME_SAMPLES)entry.
expand(INDUCEOME_FP / "phold" / "{sample}_plot" / "phold.png",
README.md:23
- Typo:
pharokka_dpshould bepharokka_dbto match the key inconfig.yml.
- - pharokka_dp: Path to the pharokka db (full path to the directory that will hold db files)
sbx_induceome.smk:247
- [nitpick] New
induceome_pharokkarule is added but there are no tests covering this step. Consider adding tests to verify Pharokka annotation output.
rule induceome_pharokka:
sbx_induceome.smk:321
- [nitpick] New
induceome_phold_plotrule is introduced without corresponding tests. Adding a test to ensure plots are generated correctly would improve reliability.
rule induceome_phold_plot:
sbx_induceome.smk:224
- [nitpick] The multiline path expression for
output.pharokkais split across lines without parentheses, which may lead to syntax errors. Consider wrapping the entire expression in parentheses or placing it on a single line.
pharokka=Path(Cfg["sbx_induceome"]["pharokka_db"])
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.