Cbrelease 4.8.6#101
Conversation
… after edit batch.
… after edit batch.
There was a problem hiding this comment.
for requested batchId there will be only one batch record , why we changed the signature to List ?
There was a problem hiding this comment.
@SaipradeepR , for single batchid , we can have multiple users enrolled in a batch(keyspace name =sunbird_courses) table name enrollment_batch_lookup.
There was a problem hiding this comment.
Don't refactor the method readById at Dao level , it should provide all details needed. Based on need modify the response received at service level.
...-actors/src/main/java/org/sunbird/learner/actors/coursebatch/CourseBatchManagementActor.java
Show resolved
Hide resolved
There was a problem hiding this comment.
sendEmailNotificationMailForBatchDatesUpdate shld be Async , req cannot wait till all notifications sent to all the users of the batch
There was a problem hiding this comment.
Update request is handled by CourseBatchManagementActor, and mail is send by CourseBatchNotificationActor, this itself will be async call to CourseBatchNotificationActor this is flow i think correct me if i am wrong.
…ion condition & start date validation
Added host of lms.service.host=http://learner-service:9000/
|
Kudos, SonarCloud Quality Gate passed!
|
SaipradeepR
changed the base branch from
cbrelease-4.8.6
to
cbrelease-4.8.6_hotfix
2 participants
Hi , @karthik-tarento,
2)Added in BatchUserDaoImpl -> userDetail & batchUser .
3)Added in CourseBatchManagementActor -> Methods added .
4)Added in CourseBatchNotificationActor .
5)Constants were added in Constants.java.
6)Added in ActorOperations -> delete event & course Notification.
7)Added on Json.key -> Host, batchupdatenotifications, regards, subject, path