fix: consistently use absolute paths for the binary containers - #13
Open
codymlewis wants to merge 3 commits into
Open
fix: consistently use absolute paths for the binary containers#13codymlewis wants to merge 3 commits into
codymlewis wants to merge 3 commits into
Conversation
wzunknown
requested changes
Aug 6, 2026
| cmd: list[str] | ||
| volumes: dict[str, dict[str, str]] | ||
| runner_image: str = DEFAULT_RUNNER_IMAGE | ||
| container = None |
Collaborator
There was a problem hiding this comment.
what about ensuring the data_dir is absoluate path at the beginning?
data_dir = data_dir.absolute()
Author
There was a problem hiding this comment.
thanks, that's much cleaner. I have made both data_dir and poc_path absolute at the beginning now, and removed the other absolute calls where unnecessary.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue
When attempting to run the PoC submission server in binary only mode, I would get the following error:
This comes from the inconstant use of absolute paths in the
run_container_binaryfunction insrc/cybergym/server/server_utils.py.Changes
Now all paths used in container volumes in the
run_container_binaryfunction are converted to absolute paths before conversion to strings.