Skip to content

fix: consistently use absolute paths for the binary containers - #13

Open
codymlewis wants to merge 3 commits into
sunblaze-ucb:mainfrom
codymlewis:main
Open

fix: consistently use absolute paths for the binary containers#13
codymlewis wants to merge 3 commits into
sunblaze-ucb:mainfrom
codymlewis:main

Conversation

@codymlewis

Copy link
Copy Markdown

Issue

When attempting to run the PoC submission server in binary only mode, I would get the following error:

Client Error for http+docker://localhost/v1.55/containers/create: Bad Request ("create cybergym-server-data/arvo/10400/vul/arvo: "cybergym-server-data/arvo/10400/vul/arvo" includes invalid characters for a local volume name, only "[a-zA-Z0-9][a-zA-Z0-9_.-]" are allowed.

This comes from the inconstant use of absolute paths in the run_container_binary function in src/cybergym/server/server_utils.py.

Changes

Now all paths used in container volumes in the run_container_binary function are converted to absolute paths before conversion to strings.

cmd: list[str]
volumes: dict[str, dict[str, str]]
runner_image: str = DEFAULT_RUNNER_IMAGE
container = None

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

what about ensuring the data_dir is absoluate path at the beginning?

data_dir = data_dir.absolute()

@codymlewis codymlewis Aug 17, 2026

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks, that's much cleaner. I have made both data_dir and poc_path absolute at the beginning now, and removed the other absolute calls where unnecessary.

@codymlewis
codymlewis requested a review from wzunknown August 18, 2026 07:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants