Skip to content

feat: 在PushReviewEntity中添加user_username字段 #96

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

Poiig
Copy link

@Poiig Poiig commented Apr 25, 2025

在PushReviewEntity中新增user_username字段,以便在推送事件处理中记录用户信息。同时优化了WeComNotifier的HTML标签处理逻辑,保留企业微信的@消息格式,并增加了日志记录。此外,改进了时间戳的格式化处理,使其更易读。

在PushReviewEntity中新增user_username字段,以便在推送事件处理中记录用户信息。同时优化了WeComNotifier的HTML标签处理逻辑,保留企业微信的@消息格式,并增加了日志记录。此外,改进了时间戳的格式化处理,使其更易读。
@Poiig Poiig requested a review from sunmh207 as a code owner April 25, 2025 02:59
@sunmh207
Copy link
Owner

user_username和author是不是重复了?

@Poiig
Copy link
Author

Poiig commented Apr 30, 2025

user_username和author是不是重复了?
user_username在Request中,有时候跟commit对象中的author不一致。可以冗余出来,提供使用。

@sunmh207
Copy link
Owner

sunmh207 commented May 7, 2025

是不是确定用途了再冗余出来?

@Poiig
Copy link
Author

Poiig commented May 7, 2025

是不是确定用途了再冗余出来?

我这边是用到了的,我们gitlab集成了微软AD认证。使用英文名作为账号,同时企微也是英文名。在进行企微机器人推送的时候,通过username能够@到对应的人,来查看review的结果。
我在使用过程中发现,author并不是很准确,取决于用户自己设置的名称,author与username是不一致的。

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants