feat: use protocol 3.2 by default, and downgrade to 3.0 if client requests#280
Merged
Conversation
sunng87
force-pushed
the
refactor/default-to-3-2
branch
from
764fbdb to
b2ac8f3
Compare
sunng87
commented
Jun 27, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In this patch I removed
UNKNOWNfromProtocolVersion. There won't be a unknown state. The server will always use3.2protocol version be default, and if client requests an alternative version the server knows about, it will downgrade to it. Otherwise, the server will start its protocol negotiation process hoping the client to know about it. This will be implemented in next patch.