resolving SimConfig.save crash#882
Open
abhinavascends wants to merge 1 commit intosuny-downstate-medical-center:developmentfrom
Open
resolving SimConfig.save crash#882abhinavascends wants to merge 1 commit intosuny-downstate-medical-center:developmentfrom
abhinavascends wants to merge 1 commit intosuny-downstate-medical-center:developmentfrom
Conversation
Open
Contributor
Author
|
Hey there @jchen6727 , I hope you would look onto the PR and give your valuable inputs on this. |
Collaborator
|
hi @abhinavascends , thank you for your contribution! We are currently refactoring this broader functionality, which includes the given method. We’ll make sure to consider your suggestion in the final version. Thanks again |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hii @jchen6727 , I saw the issue here- SimConfig.save() crashes when provided with a simple filename (e.g., 'cfg.json') instead of a full absolute path.
As the crash in SimConfig.save() was happening because the original logic relied on finding a directory separator that isn't there for local filenames,here I used
os.path.splitext()to handle the extension parsing instead. It safely grabs the extension even when there's no directory path provided, which was the main point of failure.Did these 2 changes :
os.path.dirname()for the folder path._, ext = os.path.splitext(filename)to correctly unpack the root and extension.