Skip to content

Add support to datetime on gt. gte. lt. lte. filter #8

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Oct 17, 2024

Conversation

cmoscosoz
Copy link

What kind of change does this PR introduce?

Add support to datetime on "gt." supabase filter

What is the current behavior?

throws an error: NoSuchMethodError: The method '>' was called on null.

What is the new behavior?

accepts datetime value type and int value type

Additional context

none

@dshukertjr
Copy link
Member

Thanks for the amazing work! Would you have bandwidth to add the same feature on lt, gte, and lte as well?

@cmoscosoz
Copy link
Author

@dshukertjr hey mate, no problem. leave it to me.

cheers,

@dshukertjr
Copy link
Member

Legend! Feel free to bundle all of them in a single PR too 👍

@cmoscosoz cmoscosoz changed the title Add support to datetime on gt. filter Add support to datetime on gt. gte. lt. lte. filter Oct 16, 2024
@cmoscosoz
Copy link
Author

Legend! Feel free to bundle all of them in a single PR too 👍

@dshukertjr ready for you review. cheers,

Copy link
Member

@dshukertjr dshukertjr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is awesome! Thanks for the amazing work!

@dshukertjr
Copy link
Member

Will release a new version with this update right after I merge it!

@dshukertjr dshukertjr merged commit b3bd6f6 into supabase-community:main Oct 17, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants