-
Notifications
You must be signed in to change notification settings - Fork 102
feat(completions): basic scoring algorithm for tables #150
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
psteinroe
merged 11 commits into
supabase-community:main
from
juleswritescode:completions/table-names
Dec 11, 2024
Merged
feat(completions): basic scoring algorithm for tables #150
psteinroe
merged 11 commits into
supabase-community:main
from
juleswritescode:completions/table-names
Dec 11, 2024
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
psteinroe
requested changes
Dec 9, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
very nice! just one thing about the api boundary. thanks for doing this!!
psteinroe
approved these changes
Dec 11, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome, thanks for working on the feedback!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR tries to improve the existing
pg_completions
crate – autocompletions!The goal was to autocomplete table names based on the input:
select * from us
should put theusers
table before theemails
tableselect * from private.u
should put theprivate.uncommon
before thepublic.users
tableAnd whoopdidoopdie, it works.
An overview of the changes:
Builder
&Context
as well asCompletionItem
+CompletionRelevance
to rank them (stolen fromrust-analyzer
)tower_lsp::CompletionItem
data structuretower-lsp
versionREADME.md
to thepg_completions
crate