chore/tooling ci

.github/actions/free-disk-space/action.yml

@@ -0,0 +1,16 @@
+name: Free Disk Space
+description: Free up disk space on the runner
+runs:
+  using: composite
+  steps:
+    - name: Free Disk Space (Ubuntu)
+      if: runner.os == 'Linux'
+      uses: jlumbroso/free-disk-space@main
+      with:
+        # We need to reclaim some space, but uninstalling everyting takes
+        # too long. So we'll just remove some of the larger packages.
+        # https://github.com/jlumbroso/free-disk-space/pull/26
+        android: true
+        dotnet: true
+        haskell: true
+        large-packages: false

.github/workflows/pull_request.yml

@@ -0,0 +1,183 @@
+name: Pull Request
+
+on:
+  workflow_dispatch:
+  pull_request:
+    paths: # Only run when changes are made to rust code or root Cargo
+      - "crates/**"
+      - "lib/**"
+      - "fuzz/**"
+      - "xtask/**"
+      - "Cargo.toml"
+      - "Cargo.lock"
+      - "rust-toolchain.toml"
+      - "rustfmt.toml"
+
+concurrency:
+  group: ${{ github.workflow }}-${{ github.event_name }}-${{ github.ref }}
+  cancel-in-progress: true
+
+env:
+  RUSTFLAGS: -A dead_code
+  RUST_LOG: info
+  RUST_BACKTRACE: 1
+  RUSTUP_WINDOWS_PATH_ADD_BIN: 1
+
+jobs:
+  format:
+    name: Format
+    runs-on: ubuntu-latest
+    steps:
+      - name: Checkout PR branch
+        uses: actions/checkout@v4
+      - name: Free Disk Space
+        uses: ./.github/actions/free-disk-space
+      - name: Install toolchain
+        uses: moonrepo/setup-rust@v1
+        with:
+          components: rustfmt
+          bins: taplo-cli
+          cache-base: main
+        env:
+          GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
+      - name: Run format
+        run: |
+          cargo fmt --all --check
+          taplo format --check
+
+  actionlint:
+    name: Lint GitHub Actions
+    runs-on: ubuntu-latest
+    steps:
+      - uses: actions/checkout@v4
+      - name: Download actionlint
+        id: get_actionlint
+        run: bash <(curl https://raw.githubusercontent.com/rhysd/actionlint/main/scripts/download-actionlint.bash)
+        shell: bash
+      - name: Check workflow files
+        run: ${{ steps.get_actionlint.outputs.executable }} -color
+        shell: bash
+
+  lint:
+    name: Lint Project
+    runs-on: ubuntu-latest
+    services:
+      postgres:
+        image: postgres:latest
+        env:
+          POSTGRES_USER: postgres
+          POSTGRES_PASSWORD: postgres
+          POSTGRES_DB: postgres
+        ports:
+          - 5432:5432
+    steps:
+      - name: Checkout PR Branch
+        uses: actions/checkout@v4
+        with:
+          submodules: true
+      - name: Free Disk Space
+        uses: ./.github/actions/free-disk-space
+      - name: Install toolchain
+        uses: moonrepo/setup-rust@v1
+        with:
+          components: clippy
+          cache-base: main
+        env:
+          GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
+      - name: Run clippy
+        run: |
+          cargo clippy
+          cargo run -p rules_check
+
+  # check-dependencies:
+  #   name: Check Dependencies
+  #   runs-on: ubuntu-latest
+  #   services:
+  #     postgres:
+  #       image: postgres:latest
+  #       env:
+  #         POSTGRES_USER: postgres
+  #         POSTGRES_PASSWORD: postgres
+  #         POSTGRES_DB: postgres
+  #       ports:
+  #         - 5432:5432
+  #   steps:
+  #     - name: Checkout PR Branch
+  #       uses: actions/checkout@v4
+  #       with:
+  #         submodules: true
+  #     - name: Free Disk Space
+  #       uses: ./.github/actions/free-disk-space
+  #     - name: Install toolchain
+  #       run: rustup toolchain install nightly
+  #     - name: Install udeps
+  #       run: cargo install cargo-udeps --locked
+  #     - name: Detect unused dependencies using udeps
+  #       run: cargo +nightly udeps --all-targets
+
+  test:
+    name: Test
+    runs-on: ${{ matrix.os }}
+    strategy:
+      matrix:
+        include:
+          # reactive once we upgrade to the latest version of pg_query that is windows-compatible
+          # - os: windows-latest
+          - os: ubuntu-latest
+    steps:
+      - name: Checkout PR branch
+        uses: actions/checkout@v4
+        with:
+          submodules: true
+      - name: Free Disk Space
+        uses: ./.github/actions/free-disk-space
+      - name: Install toolchain
+        uses: moonrepo/setup-rust@v1
+        with:
+          cache-base: main
+        env:
+          GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
+
+      # running containers via `services` only works on linux
+      # https://github.com/actions/runner/issues/1866
+      - name: Setup postgres
+        uses: ikalnytskyi/action-setup-postgres@v7
+      - name: Run tests
+        run: cargo test --workspace
+
+  codegen:
+    name: Check Codegen
+    runs-on: ubuntu-latest
+    services:
+      postgres:
+        image: postgres:latest
+        env:
+          POSTGRES_USER: postgres
+          POSTGRES_PASSWORD: postgres
+          POSTGRES_DB: postgres
+        ports:
+          - 5432:5432
+    steps:
+      - name: Checkout PR branch
+        uses: actions/checkout@v4
+        with:
+          submodules: true
+      - name: Free Disk Space
+        uses: ./.github/actions/free-disk-space
+      - name: Install toolchain
+        uses: moonrepo/setup-rust@v1
+        with:
+          cache-base: main
+        env:
+          GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
+      - name: Run the analyser codegen
+        run: cargo run -p xtask_codegen -- analyser
+      - name: Run the configuration codegen
+        run: cargo run -p xtask_codegen -- configuration
+      - name: Check for git diff
+        run: |
+          if [[ $(git status --porcelain) ]]; then
+            git status
+            git diff
+            exit 1
+          fi

crates/pg_completions/src/context.rs

@@ -29,7 +29,7 @@ impl TryFrom<&str> for ClauseType {
                     panic!("{}", message);
                 }
 
-                return Err(message);
+                Err(message)
             }
         }
     }
@@ -215,7 +215,7 @@ mod tests {
 
             let params = crate::CompletionParams {
                 position: (position as u32).into(),
-                text: text,
+                text,
                 tree: Some(&tree),
                 schema: &pg_schema_cache::SchemaCache::new(),
             };
@@ -247,7 +247,7 @@ mod tests {
             let tree = get_tree(text.as_str());
             let params = crate::CompletionParams {
                 position: (position as u32).into(),
-                text: text,
+                text,
                 tree: Some(&tree),
                 schema: &pg_schema_cache::SchemaCache::new(),
             };
@@ -281,7 +281,7 @@ mod tests {
             let tree = get_tree(text.as_str());
             let params = crate::CompletionParams {
                 position: (position as u32).into(),
-                text: text,
+                text,
                 tree: Some(&tree),
                 schema: &pg_schema_cache::SchemaCache::new(),
             };
@@ -306,14 +306,14 @@ mod tests {
 
             let params = crate::CompletionParams {
                 position: (position as u32).into(),
-                text: text,
+                text,
                 tree: Some(&tree),
                 schema: &pg_schema_cache::SchemaCache::new(),
             };
 
             let ctx = CompletionContext::new(&params);
 
-            let node = ctx.ts_node.map(|n| n.clone()).unwrap();
+            let node = ctx.ts_node.unwrap();
 
             assert_eq!(ctx.get_ts_node_content(node), Some("select"));
 
@@ -334,14 +334,14 @@ mod tests {
 
         let params = crate::CompletionParams {
             position: (position as u32).into(),
-            text: text,
+            text,
             tree: Some(&tree),
             schema: &pg_schema_cache::SchemaCache::new(),
         };
 
         let ctx = CompletionContext::new(&params);
 
-        let node = ctx.ts_node.map(|n| n.clone()).unwrap();
+        let node = ctx.ts_node.unwrap();
 
         assert_eq!(ctx.get_ts_node_content(node), Some("from"));
         assert_eq!(
@@ -360,14 +360,14 @@ mod tests {
 
         let params = crate::CompletionParams {
             position: (position as u32).into(),
-            text: text,
+            text,
             tree: Some(&tree),
             schema: &pg_schema_cache::SchemaCache::new(),
         };
 
         let ctx = CompletionContext::new(&params);
 
-        let node = ctx.ts_node.map(|n| n.clone()).unwrap();
+        let node = ctx.ts_node.unwrap();
 
         assert_eq!(ctx.get_ts_node_content(node), Some(""));
         assert_eq!(ctx.wrapping_clause_type, None);
@@ -385,14 +385,14 @@ mod tests {
 
         let params = crate::CompletionParams {
             position: (position as u32).into(),
-            text: text,
+            text,
             tree: Some(&tree),
             schema: &pg_schema_cache::SchemaCache::new(),
         };
 
         let ctx = CompletionContext::new(&params);
 
-        let node = ctx.ts_node.map(|n| n.clone()).unwrap();
+        let node = ctx.ts_node.unwrap();
 
         assert_eq!(ctx.get_ts_node_content(node), Some("fro"));
         assert_eq!(ctx.wrapping_clause_type, Some(ClauseType::Select));

crates/pg_completions/src/test_helper.rs

@@ -34,10 +34,9 @@ pub(crate) async fn get_test_deps(
 pub(crate) fn get_text_and_position(sql: &str) -> (usize, String) {
     // the cursor is to the left of the `CURSOR_POS`
     let position = sql
-        .find(|c| c == CURSOR_POS)
+        .find(CURSOR_POS)
         .expect("Please insert the CURSOR_POS into your query.")
-        .checked_sub(1)
-        .unwrap_or(0);
+        .saturating_sub(1);
 
     let text = sql.replace(CURSOR_POS, "");