fix: change handling

crates/pg_analyse/src/filter.rs

@@ -42,7 +42,7 @@ impl<'analysis> AnalysisFilter<'analysis> {
     /// Return `true` if the group `G` matches this filter
     pub fn match_group<G: RuleGroup>(&self) -> bool {
         self.match_category::<G::Category>()
-            && self.enabled_rules.map_or(true, |enabled_rules| {
+            && self.enabled_rules.is_none_or(|enabled_rules| {
                 enabled_rules.iter().any(|filter| filter.match_group::<G>())
             })
             && !self
@@ -54,7 +54,7 @@ impl<'analysis> AnalysisFilter<'analysis> {
     /// Return `true` if the rule `R` matches this filter
     pub fn match_rule<R: Rule>(&self) -> bool {
         self.match_category::<<R::Group as RuleGroup>::Category>()
-            && self.enabled_rules.map_or(true, |enabled_rules| {
+            && self.enabled_rules.is_none_or(|enabled_rules| {
                 enabled_rules.iter().any(|filter| filter.match_rule::<R>())
             })
             && !self
@@ -94,13 +94,13 @@ impl<'a> RuleFilter<'a> {
     }
 }
 
-impl<'a> Debug for RuleFilter<'a> {
+impl Debug for RuleFilter<'_> {
     fn fmt(&self, f: &mut Formatter<'_>) -> std::fmt::Result {
         Display::fmt(self, f)
     }
 }
 
-impl<'a> Display for RuleFilter<'a> {
+impl Display for RuleFilter<'_> {
     fn fmt(&self, f: &mut Formatter<'_>) -> std::fmt::Result {
         match self {
             RuleFilter::Group(group) => {
@@ -113,7 +113,7 @@ impl<'a> Display for RuleFilter<'a> {
     }
 }
 
-impl<'a> pg_console::fmt::Display for RuleFilter<'a> {
+impl pg_console::fmt::Display for RuleFilter<'_> {
     fn fmt(&self, fmt: &mut pg_console::fmt::Formatter) -> std::io::Result<()> {
         match self {
             RuleFilter::Group(group) => {

crates/pg_cli/src/commands/daemon.rs

@@ -180,7 +180,7 @@ pub(crate) fn read_most_recent_log_file(
 
     let most_recent = fs::read_dir(biome_log_path)?
         .flatten()
-        .filter(|file| file.file_type().map_or(false, |ty| ty.is_file()))
+        .filter(|file| file.file_type().is_ok_and(|ty| ty.is_file()))
         .filter_map(|file| {
             match file
                 .file_name()

crates/pg_cli/src/commands/mod.rs

@@ -230,7 +230,7 @@ impl PgLspCommand {
 
     pub fn is_verbose(&self) -> bool {
         self.cli_options()
-            .map_or(false, |cli_options| cli_options.verbose)
+            .is_some_and(|cli_options| cli_options.verbose)
     }
 
     pub fn log_level(&self) -> LoggingLevel {

crates/pg_cli/src/execute/traverse.rs

@@ -413,7 +413,7 @@ pub(crate) struct TraversalOptions<'ctx, 'app> {
     pub(crate) evaluated_paths: RwLock<BTreeSet<PgLspPath>>,
 }
 
-impl<'ctx, 'app> TraversalOptions<'ctx, 'app> {
+impl TraversalOptions<'_, '_> {
     pub(crate) fn increment_changed(&self, path: &PgLspPath) {
         self.changed.fetch_add(1, Ordering::Relaxed);
         self.evaluated_paths
@@ -441,7 +441,7 @@ impl<'ctx, 'app> TraversalOptions<'ctx, 'app> {
     }
 }
 
-impl<'ctx, 'app> TraversalContext for TraversalOptions<'ctx, 'app> {
+impl TraversalContext for TraversalOptions<'_, '_> {
     fn interner(&self) -> &PathInterner {
         &self.interner
     }

crates/pg_cli/src/reporter/github.rs

@@ -16,7 +16,7 @@ impl Reporter for GithubReporter {
 }
 pub(crate) struct GithubReporterVisitor<'a>(pub(crate) &'a mut dyn Console);
 
-impl<'a> ReporterVisitor for GithubReporterVisitor<'a> {
+impl ReporterVisitor for GithubReporterVisitor<'_> {
     fn report_summary(
         &mut self,
         _execution: &Execution,

crates/pg_cli/src/reporter/gitlab.rs

@@ -57,7 +57,7 @@ impl<'a> GitLabReporterVisitor<'a> {
     }
 }
 
-impl<'a> ReporterVisitor for GitLabReporterVisitor<'a> {
+impl ReporterVisitor for GitLabReporterVisitor<'_> {
     fn report_summary(&mut self, _: &Execution, _: TraversalSummary) -> std::io::Result<()> {
         Ok(())
     }
@@ -80,7 +80,7 @@ struct GitLabDiagnostics<'a>(
     Option<&'a Path>,
 );
 
-impl<'a> GitLabDiagnostics<'a> {
+impl GitLabDiagnostics<'_> {
     fn attempt_to_relativize(&self, subject: &str) -> Option<PathBuf> {
         let Ok(resolved) = Path::new(subject).absolutize() else {
             return None;
@@ -116,7 +116,7 @@ impl<'a> GitLabDiagnostics<'a> {
     }
 }
 
-impl<'a> Display for GitLabDiagnostics<'a> {
+impl Display for GitLabDiagnostics<'_> {
     fn fmt(&self, fmt: &mut Formatter) -> std::io::Result<()> {
         let mut hasher = self.1.write().unwrap();
         let gitlab_diagnostics: Vec<_> = self

crates/pg_cli/src/reporter/junit.rs

@@ -24,7 +24,7 @@ struct JunitDiagnostic<'a> {
     diagnostic: &'a Error,
 }
 
-impl<'a> Display for JunitDiagnostic<'a> {
+impl Display for JunitDiagnostic<'_> {
     fn fmt(&self, f: &mut Formatter<'_>) -> std::fmt::Result {
         self.diagnostic.description(f)
     }
@@ -39,7 +39,7 @@ impl<'a> JunitReporterVisitor<'a> {
     }
 }
 
-impl<'a> ReporterVisitor for JunitReporterVisitor<'a> {
+impl ReporterVisitor for JunitReporterVisitor<'_> {
     fn report_summary(
         &mut self,
         _execution: &Execution,

crates/pg_cli/src/reporter/terminal.rs

@@ -53,7 +53,7 @@ struct FixedPathsDiagnostic {
 
 pub(crate) struct ConsoleReporterVisitor<'a>(pub(crate) &'a mut dyn Console);
 
-impl<'a> ReporterVisitor for ConsoleReporterVisitor<'a> {
+impl ReporterVisitor for ConsoleReporterVisitor<'_> {
     fn report_summary(
         &mut self,
         execution: &Execution,
@@ -132,7 +132,7 @@ impl fmt::Display for Files {
 
 struct SummaryDetail<'a>(pub(crate) &'a TraversalMode, usize);
 
-impl<'a> fmt::Display for SummaryDetail<'a> {
+impl fmt::Display for SummaryDetail<'_> {
     fn fmt(&self, fmt: &mut Formatter) -> io::Result<()> {
         if self.1 > 0 {
             fmt.write_markup(markup! {
@@ -147,7 +147,7 @@ impl<'a> fmt::Display for SummaryDetail<'a> {
 }
 struct SummaryTotal<'a>(&'a TraversalMode, usize, &'a Duration);
 
-impl<'a> fmt::Display for SummaryTotal<'a> {
+impl fmt::Display for SummaryTotal<'_> {
     fn fmt(&self, fmt: &mut Formatter) -> io::Result<()> {
         let files = Files(self.1);
         match self.0 {
@@ -165,7 +165,7 @@ pub(crate) struct ConsoleTraversalSummary<'a>(
     pub(crate) &'a TraversalMode,
     pub(crate) &'a TraversalSummary,
 );
-impl<'a> fmt::Display for ConsoleTraversalSummary<'a> {
+impl fmt::Display for ConsoleTraversalSummary<'_> {
     fn fmt(&self, fmt: &mut Formatter) -> io::Result<()> {
         let summary = SummaryTotal(self.0, self.1.changed + self.1.unchanged, &self.1.duration);
         let detail = SummaryDetail(self.0, self.1.changed);

crates/pg_completions/Cargo.toml

@@ -16,9 +16,9 @@ async-std = "1.12.0"
 
 text-size.workspace = true
 
+pg_schema_cache.workspace = true
 serde                     = { workspace = true, features = ["derive"] }
 serde_json                = { workspace = true }
-pg_schema_cache.workspace = true
 tree-sitter.workspace     = true
 tree_sitter_sql.workspace = true
 

crates/pg_completions/src/relevance.rs

@@ -6,7 +6,7 @@ pub(crate) enum CompletionRelevanceData<'a> {
     Function(&'a pg_schema_cache::Function),
 }
 
-impl<'a> CompletionRelevanceData<'a> {
+impl CompletionRelevanceData<'_> {
     pub fn get_score(self, ctx: &CompletionContext) -> i32 {
         CompletionRelevance::from(self).into_score(ctx)
     }
@@ -27,7 +27,7 @@ pub(crate) struct CompletionRelevance<'a> {
     data: CompletionRelevanceData<'a>,
 }
 
-impl<'a> CompletionRelevance<'a> {
+impl CompletionRelevance<'_> {
     pub fn into_score(mut self, ctx: &CompletionContext) -> i32 {
         self.check_matches_schema(ctx);
         self.check_matches_query_input(ctx);

crates/pg_configuration/src/analyser/mod.rs

@@ -362,7 +362,7 @@ impl serde::Serialize for RuleSelector {
 impl<'de> serde::Deserialize<'de> for RuleSelector {
     fn deserialize<D: serde::Deserializer<'de>>(deserializer: D) -> Result<Self, D::Error> {
         struct Visitor;
-        impl<'de> serde::de::Visitor<'de> for Visitor {
+        impl serde::de::Visitor<'_> for Visitor {
             type Value = RuleSelector;
             fn expecting(&self, formatter: &mut std::fmt::Formatter) -> std::fmt::Result {
                 formatter.write_str("<group>/<ruyle_name>")

crates/pg_lsp_new/Cargo.toml

@@ -16,10 +16,10 @@ anyhow              = { workspace = true }
 biome_deserialize   = { workspace = true }
 futures             = "0.3.31"
 pg_analyse          = { workspace = true }
+pg_completions      = { workspace = true }
 pg_configuration    = { workspace = true }
 pg_console          = { workspace = true }
 pg_diagnostics      = { workspace = true }
-pg_completions      = { workspace = true }
 pg_fs               = { workspace = true }
 pg_lsp_converters   = { workspace = true }
 pg_text_edit        = { workspace = true }

crates/pg_lsp_new/src/handlers/text_document.rs

@@ -5,7 +5,7 @@ use pg_workspace_new::workspace::{
     ChangeFileParams, ChangeParams, CloseFileParams, GetFileContentParams, OpenFileParams,
 };
 use tower_lsp::lsp_types;
-use tracing::{error, field, info};
+use tracing::{error, field};
 
 /// Handler for `textDocument/didOpen` LSP notification
 #[tracing::instrument(

crates/pg_query_ext/src/lib.rs

@@ -26,8 +26,7 @@ pub fn parse(sql: &str) -> Result<NodeEnum> {
             .nodes()
             .iter()
             .find(|n| n.1 == 1)
-            .unwrap()
-            .0
-            .to_enum()
-    })
+            .map(|n| n.0.to_enum())
+            .ok_or_else(|| Error::Parse("Unable to find root node".to_string()))
+    })?
 }

crates/pg_statement_splitter/src/parser.rs

@@ -186,6 +186,6 @@ impl Parser {
 }
 
 fn is_irrelevant_token(t: &Token) -> bool {
-    return WHITESPACE_TOKENS.contains(&t.kind)
-        && (t.kind != SyntaxKind::Newline || t.text.chars().count() == 1);
+    WHITESPACE_TOKENS.contains(&t.kind)
+        && (t.kind != SyntaxKind::Newline || t.text.chars().count() == 1)
 }

crates/pg_syntax/src/statement_parser.rs

@@ -435,7 +435,7 @@ struct Ancestors<'a> {
     current_node: NodeIndex<DefaultIx>,
 }
 
-impl<'a> Iterator for Ancestors<'a> {
+impl Iterator for Ancestors<'_> {
     type Item = NodeIndex<DefaultIx>;
 
     fn next(&mut self) -> Option<Self::Item> {

crates/pg_type_resolver/src/types.rs

@@ -27,7 +27,7 @@ pub fn resolve_type(node: &pg_query_ext::NodeEnum, schema_cache: &SchemaCache) -
                                 .types
                                 .iter()
                                 .filter(|t| {
-                                    types.iter().any(|i| &i == &&t.name) && t.schema == "pg_catalog"
+                                    types.iter().any(|i| i == &t.name) && t.schema == "pg_catalog"
                                 })
                                 .map(|t| t.id)
                                 .collect(),
@@ -63,8 +63,7 @@ pub fn resolve_type(node: &pg_query_ext::NodeEnum, schema_cache: &SchemaCache) -
                                 .types
                                 .iter()
                                 .filter(|t| {
-                                    (types.iter().any(|i| &i == &&t.name)
-                                        && t.schema == "pg_catalog")
+                                    (types.iter().any(|i| i == &t.name) && t.schema == "pg_catalog")
                                         || t.enums.values.contains(&v.sval)
                                 })
                                 .map(|t| t.id)

crates/pg_workspace_new/Cargo.toml

@@ -18,10 +18,10 @@ futures                   = "0.3.31"
 ignore                    = { workspace = true }
 pg_analyse                = { workspace = true, features = ["serde"] }
 pg_analyser               = { workspace = true }
+pg_completions            = { workspace = true }
 pg_configuration          = { workspace = true }
 pg_console                = { workspace = true }
 pg_diagnostics            = { workspace = true }
-pg_completions            = { workspace = true }
 pg_fs                     = { workspace = true, features = ["serde"] }
 pg_query_ext              = { workspace = true }
 pg_schema_cache           = { workspace = true }

crates/pg_workspace_new/src/dome.rs

@@ -37,27 +37,27 @@ pub struct DomeIterator<'a> {
 
 impl<'a> DomeIterator<'a> {
     pub fn next_config(&mut self) -> Option<&'a PgLspPath> {
-        return if let Some(path) = self.iter.peek() {
+        if let Some(path) = self.iter.peek() {
             if path.is_config() {
                 self.iter.next()
             } else {
                 None
             }
         } else {
             None
-        };
+        }
     }
 
     pub fn next_ignore(&mut self) -> Option<&'a PgLspPath> {
-        return if let Some(path) = self.iter.peek() {
+        if let Some(path) = self.iter.peek() {
             if path.is_ignore() {
                 self.iter.next()
             } else {
                 None
             }
         } else {
             None
-        };
+        }
     }
 }
 
@@ -69,4 +69,4 @@ impl<'a> Iterator for DomeIterator<'a> {
     }
 }
 
-impl<'a> FusedIterator for DomeIterator<'a> {}
+impl FusedIterator for DomeIterator<'_> {}

crates/pg_workspace_new/src/matcher/pattern.rs

@@ -149,7 +149,7 @@ impl Pattern {
             tokens.push(AnyRecursiveSequence);
         } else {
             // A pattern is absolute if it starts with a path separator, eg. "/home" or "\\?\C:\Users"
-            let mut is_absolute = chars.first().map_or(false, |c| path::is_separator(*c));
+            let mut is_absolute = chars.first().is_some_and(|c| path::is_separator(*c));
 
             // On windows a pattern may also be absolute if it starts with a
             // drive letter, a colon and a separator, eg. "c:/Users" or "G:\Users"
@@ -368,7 +368,7 @@ impl Pattern {
     /// `Pattern` using the default match options (i.e. `MatchOptions::new()`).
     pub fn matches_path(&self, path: &Path) -> bool {
         // FIXME (#9639): This needs to handle non-utf8 paths
-        path.to_str().map_or(false, |s| self.matches(s))
+        path.to_str().is_some_and(|s| self.matches(s))
     }
 
     /// Return if the given `str` matches this `Pattern` using the specified
@@ -381,8 +381,7 @@ impl Pattern {
     /// `Pattern` using the specified match options.
     pub fn matches_path_with(&self, path: &Path, options: MatchOptions) -> bool {
         // FIXME (#9639): This needs to handle non-utf8 paths
-        path.to_str()
-            .map_or(false, |s| self.matches_with(s, options))
+        path.to_str().is_some_and(|s| self.matches_with(s, options))
     }
 
     /// Access the original glob pattern.
@@ -551,7 +550,7 @@ fn chars_eq(a: char, b: char, case_sensitive: bool) -> bool {
         true
     } else if !case_sensitive && a.is_ascii() && b.is_ascii() {
         // FIXME: work with non-ascii chars properly (issue #9084)
-        a.to_ascii_lowercase() == b.to_ascii_lowercase()
+        a.eq_ignore_ascii_case(&b)
     } else {
         a == b
     }

crates/pg_workspace_new/src/settings.rs

@@ -48,7 +48,7 @@ impl<'a> SettingsHandle<'a> {
     }
 }
 
-impl<'a> AsRef<Settings> for SettingsHandle<'a> {
+impl AsRef<Settings> for SettingsHandle<'_> {
     fn as_ref(&self) -> &Settings {
         &self.inner
     }
@@ -62,7 +62,7 @@ impl<'a> SettingsHandleMut<'a> {
     }
 }
 
-impl<'a> AsMut<Settings> for SettingsHandleMut<'a> {
+impl AsMut<Settings> for SettingsHandleMut<'_> {
     fn as_mut(&mut self) -> &mut Settings {
         &mut self.inner
     }

crates/pg_workspace_new/src/workspace.rs

@@ -286,7 +286,7 @@ impl<'app, W: Workspace + ?Sized> FileGuard<'app, W> {
     // }
 }
 
-impl<'app, W: Workspace + ?Sized> Drop for FileGuard<'app, W> {
+impl<W: Workspace + ?Sized> Drop for FileGuard<'_, W> {
     fn drop(&mut self) {
         self.workspace
             .close_file(CloseFileParams {