Skip to content

wasm draft #234

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 3 commits into from
Closed

wasm draft #234

wants to merge 3 commits into from

Conversation

psteinroe
Copy link
Collaborator

@psteinroe psteinroe commented Mar 12, 2025

while trying to add wasm support I realised we need to fix some other things first. keeping this (very messy) pr open to have a note pad and structure my next attempt:

  • add our own pglt_text_size crate for schemars implementation and migrate to it
  • go through all relevant crates (mainly diagnostics and workspace) and add the missing schemars implementations / derive attributes
  • streamline feature names to be "schemars" / "serde" everywhere
  • decide if we want to rename to snake_case or camelCase. biome uses camel case because their config is in json. we use mostly snake because we use toml. but for generating ts types, camel makes more sense. we might also go back to a json config to "fix" this :D. once decided, make sure to add it everywhere
  • add workspace_types behind a feature flag to generate ts types

I will keep this PR open but will create new prs to do this step by step

@psteinroe psteinroe closed this Mar 18, 2025
@psteinroe psteinroe deleted the feat/wasm branch March 18, 2025 19:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant