refactor: migrate to jsonc config #239
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: Julian Domke <[email protected]>
juleswritescode
approved these changes
Mar 17, 2025
psteinroe
added a commit
that referenced
this pull request
Mar 17, 2025
* chore: add our own text-size * fix: test * chore: cleanup feature gates * chore: cleanup remaining feature gates * refactor: migrate to json config * fix: lint * feat: add schema field * migrate to jsonc config * fix: run docs codegen * Update configuration.rs Co-authored-by: Julian Domke <[email protected]> * add unit tests * fix: replace_secion --------- Co-authored-by: Julian Domke <[email protected]>
psteinroe
added a commit
that referenced
this pull request
Mar 17, 2025
* chore: add our own text-size * fix: test * chore: cleanup feature gates * chore: cleanup remaining feature gates * refactor: migrate to json config * fix: lint * feat: add schema field * migrate to jsonc config * feat: wasm attempt 2 * make pglt_wasm crate build * setup bun monorepo * feat: bindings * adapt generate packages * fix: add pg to job * fix: run docs codegen * fixes * fixes * fixes * Update configuration.rs Co-authored-by: Julian Domke <[email protected]> * add unit tests * fix: replace_secion * fix: remove wasm tools * remove musl * remove biome ref * remove biome ref * refactor: migrate to jsonc config (#239) * chore: add our own text-size * fix: test * chore: cleanup feature gates * chore: cleanup remaining feature gates * refactor: migrate to json config * fix: lint * feat: add schema field * migrate to jsonc config * fix: run docs codegen * Update configuration.rs Co-authored-by: Julian Domke <[email protected]> * add unit tests * fix: replace_secion --------- Co-authored-by: Julian Domke <[email protected]> --------- Co-authored-by: Julian Domke <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
as per title.
our new config is
.jsonc, which is "json with comments". serde doesnt support comments so we strip them before parsing.also unified all
rename_allconfigs tocamelCase.and added
$schemato thejsoncconfig so we should get auto-complete if the editor supports it.we will need to update the path to the schema file (if its not available locally, which is preferred) once we have our domain.