Skip to content

fix(completions): complete right columns right after JOIN ON #390

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
May 6, 2025

Conversation

juleswritescode
Copy link
Collaborator

Before, we were only completing columns in a JOIN in a "Binary Expression".
But for TreeSitter to recognize a Binary Expression, we need an = sign.

So this wouldn't complete, since there's no = sign:
select * from users u join posts p on u.{}

Now, we're checking for the ON node, and completing columns if we're after it.

Note: Multiple joins are each individual join clauses with their own separate ON nodes, so there's no intereference:

select * 
from 
users u
join posts p on u.id = post.user_id -- join clause 1
join {} -- join clause 2

We won't autocompete a column, since there's no ON node in join cluase 2 🥳

@juleswritescode juleswritescode requested a review from psteinroe May 6, 2025 07:58
Comment on lines +351 to +352
// sadly, we need to manually iterate over the children –
// `node.child_by_field_id(..)` does not work as expected
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we might wanna fix this upstream at some point

@juleswritescode juleswritescode merged commit 5945c1b into main May 6, 2025
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants