fix(completions): handle UTF-8 cursor sanitization#763
Closed
psteinroe wants to merge 1 commit into
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Handle completions when the cursor is adjacent to multi-byte UTF-8 characters without panicking. Sanitization now treats completion positions as byte offsets and uses char-boundary-safe helpers before slicing or inspecting surrounding characters.
UTF-8-safe sanitization
The completion sanitizer now avoids direct byte slicing like
[1..]and no longer compares byte positions against character indices. A regression test covers completion afterè, which previously reproduced the reported crash.Validated with targeted completion and sanitization tests; full DB-backed completion tests could not run locally because the test Postgres/Docker daemon was unavailable.
Fixes #762