Add session failsafe and option to require a session for requests #1071
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| package io.github.jan.supabase.auth.exception | ||
|
|
||
| //TODO: Add actual message and docs | ||
| class TokenExpiredException: Exception("The token has expired") No newline at end of file |
Check warning
Code scanning / detekt
Public classes, interfaces and objects require documentation. Warning
jan-tennert
changed the title
2 tasks
Auth/src/commonMain/kotlin/io/github/jan/supabase/auth/AuthenticatedSupabaseApi.kt
Fixed
Show fixed
Hide fixed
Auth/src/commonMain/kotlin/io/github/jan/supabase/auth/AuthenticatedSupabaseApi.kt
Fixed
Show fixed
Hide fixed
Auth/src/commonMain/kotlin/io/github/jan/supabase/auth/AuthenticatedSupabaseApi.kt
Fixed
Show fixed
Hide fixed
| object SessionNetworkInterceptor: NetworkInterceptor.Before { | ||
|
|
||
| override suspend fun call(builder: HttpRequestBuilder, supabase: SupabaseClient) { | ||
| val authHeader = builder.headers[HttpHeaders.Authorization]?.replace("Bearer ", "") |
Check warning
Code scanning / detekt
Property is unused and should be removed. Warning
| @SupabaseExperimental | ||
| var checkSessionOnRequest: Boolean = true | ||
|
|
||
| var requireValidSession: Boolean = false |
Check warning
Code scanning / detekt
Public properties require documentation. Warning
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce?
Feature
What is the new behavior?
AuthConfig#checkSessionOnRequest) to check any request made with the current user session and if the session is expired try to force a refresh or let the request fail.Realtime,Functions,Postgrest,Storageto require a session to make requests from this plugin (aka disable using the api key as a fallback option)