fix(analytics): use correct default access token value #133
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce?
Bug fix – fixes incorrect default key handling and conditional logic for analytics secrets in the Helm template.
What is the current behavior?
The Helm template contains duplicated and inconsistent conditional blocks for secret.analytics.secretRef, causing incorrect default keys (publicAccessToken / privateAccessToken) to be resolved or applied.
As a result, the rendered manifest may reference the wrong secret key or produce invalid/duplicated sections, leading to misconfigured analytics credentials at runtime.
What is the new behavior?
The Helm template logic has been corrected to properly resolve analytics secret references and default keys.