refactor(db): centralize DB host/port resolution via helpers #136
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR introduces the
supabase.db.hostandsupabase.db.porthelper templates to centralize database connection logic across the Helm chart.With these helpers, services no longer need to implement conditional logic for internal vs external databases individually. All components now consistently consume
DB_HOSTandDB_PORTfrom shared helpers, reducing duplication and configuration drift.The
values.yamlfile was also updated to better document and support external database configuration viadb.external.What kind of change does this PR introduce?
What is the current behavior?
Each service defines its own logic to resolve database connection settings, often relying on:
db.enabledDB_HOSTandDB_PORTThis leads to duplicated logic across templates and makes external database configuration harder to maintain and reason about.
What is the new behavior?
supabase.db.hostsupabase.db.portDB_HOSTandDB_PORTfrom these shared helpers