fix(studio): use analytics secretRef if configured #94
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This is just straight up missing, why not merge this? Everyone will get issues if using secretRef for the analytics apiKey. |
|
@themightychris I got the same error and solved it with the same code as in the commit , it works |
kastakhov
added a commit
to wiseinfotec/helm-charts
that referenced
this pull request
Jul 27, 2025
Merging some pull requests from [original](https://github.com/supabase-community/supabase-kubernetes) repository. - supabase-community/supabase-kubernetes#62 - supabase-community/supabase-kubernetes#89 - supabase-community/supabase-kubernetes#91 - supabase-community/supabase-kubernetes#94 - supabase-community/supabase-kubernetes#95 - supabase-community/supabase-kubernetes#96 - supabase-community/supabase-kubernetes#101 - supabase-community/supabase-kubernetes#106 - supabase-community/supabase-kubernetes#107 - supabase-community/supabase-kubernetes#113 --------- Co-authored-by: Varantha <sam@kiessler.co.uk> Co-authored-by: naki3004 <45875285+naki3004@users.noreply.github.com> Co-authored-by: jingyu <francismajere@gmail.com> Co-authored-by: Chris Alfano <chris@jarv.us> Co-authored-by: Simone Lazzaris <slazzaris@gmail.com> Co-authored-by: Mikey032 <26899585+Mikey032@users.noreply.github.com> Co-authored-by: Upik Saleh <upxsal@gmail.com> Co-authored-by: Scott Beardsley <scott@beards.ly>
Contributor
|
Hey @themightychris thanks for the contribution. Previously, Studio only required LOGFLARE_API_KEY, and the validation you added was not present at the time. Currently, LOGFLARE_API_KEY is deprecated, and only LOGFLARE_PRIVATE_ACCESS_TOKEN and LOGFLARE_PUBLIC_ACCESS_TOKEN are used. The secretRef fix was introduced in PR #131 together with the variable changes. Cc @aantti |
Contributor
|
Closing this one for now :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce?
Bug fix
What is the current behavior?
studio pod fails to start if analytics.secretRef is configured
What is the new behavior?
studio analytics secret uses same pattern as analytics and vector containers
Additional context
How has no one hit this before?