fix(mailer): include SiteURL in notification template data#2532
Open
jeffreywescott wants to merge 1 commit into
Open
fix(mailer): include SiteURL in notification template data#2532jeffreywescott wants to merge 1 commit into
jeffreywescott wants to merge 1 commit into
Conversation
The seven notification mail builders (PasswordChanged, EmailChanged,
PhoneChanged, IdentityLinked, IdentityUnlinked, MFAFactorEnrolled,
MFAFactorUnenrolled) omitted SiteURL from their template data maps,
so templates referencing {{ .SiteURL }} rendered an empty string at
runtime. The standard mail builders (Invite, Confirmation, Recovery,
MagicLink, EmailChange, Reauthentication) already include it, and
checkDefaults whitelists SiteURL for all template types, so this was
an oversight rather than an intentional restriction.
Closes supabase#2468
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The seven notification mail builders (
PasswordChanged,EmailChanged,PhoneChanged,IdentityLinked,IdentityUnlinked,MFAFactorEnrolled,MFAFactorUnenrolled) omittedSiteURLfrom their template data maps, so templates referencing{{ .SiteURL }}render an empty string at runtime. The standard mail builders (Invite,Confirmation,Recovery,MagicLink,EmailChange,Reauthentication) already include it, andcheckDefaultsintemplate.goalready whitelistsSiteURLfor all template types — so this looks like an oversight from when notification templates were added, not an intentional restriction.Closes #2468
Test plan
go build ./...passesgo test ./internal/mailer/templatemailer/...passesgofmtclean