Skip to content

fix: resolve \ir relative paths in single file pg_tap tests #4845

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
7ttp wants to merge 9 commits into
base: develop
Choose a base branch
from
Open

fix: resolve \ir relative paths in single file pg_tap tests #4845

Changes from 1 commit
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
85209ea
fix: resolve \ir relative paths in single file pg_tap tests
7ttp Feb 11, 2026
3dcba8a
fix(db): traverse and mount files imported via \ir in pg_tap tests
7ttp Feb 12, 2026
f4b7c8c
test(db): add unit tests for \ir import traversal
7ttp Feb 12, 2026
4eda876
lint
7ttp Feb 12, 2026
3bb4f73
fix(db): use set lookup to identify test files vs imports
7ttp Feb 14, 2026
d71d0dc
fix(db): handle indented \ir and multi-directory test files
7ttp Feb 14, 2026
c4248c8
Merge branch 'develop' into fix/ir
avallete Feb 18, 2026
43c38e4
Merge branch 'develop' into fix/ir
7ttp Mar 2, 2026
98e1ea0
Merge branch 'develop' into fix/ir
7ttp Mar 10, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 6 additions & 2 deletions internal/db/test/test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -42,14 +42,18 @@ func Run(ctx context.Context, testFiles []string, config pgconn.Config, fsys afe
fp = filepath.Join(utils.CurrentDirAbs, fp)
}
dockerPath := utils.ToDockerPath(fp)
cmd = append(cmd, dockerPath)
binds[i] = fmt.Sprintf("%s:%s:ro", fp, dockerPath)
if workingDir == "" {
workingDir = dockerPath
if path.Ext(dockerPath) != "" {
workingDir = path.Dir(dockerPath)
}
}
relPath := dockerPath
if path.Ext(dockerPath) != "" {
relPath = path.Base(dockerPath)
}
cmd = append(cmd, relPath)
binds[i] = fmt.Sprintf("%s:%s:ro", fp, dockerPath)
Copy link
Contributor

@sweatybridge sweatybridge Feb 11, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What if the file imported by \ir imports another file using \ir?

To support this properly, we need to traverse all the files imported. Easiest way is to use a regex expression. You can refer to this example https://github.com/supabase/cli/blob/develop/pkg/function/deno.go#L114

Copy link
Contributor

@sweatybridge sweatybridge Feb 11, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If you end up implementing that, please also write a unit test to cover these cases.

Copy link
Contributor Author

@7ttp 7ttp Feb 14, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done 💚😅!
Added traverseImports with regex pattern matching and unit tests for nested imports, circular imports and relative paths

}
if viper.GetBool("DEBUG") {
cmd = append(cmd, "--verbose")
Expand Down
Loading