Skip to content

Use Postgres state and explicit sync waits in the crash-recovery test - #993

Open
jmqd wants to merge 8 commits into
mainfrom
test/postgres-store-dirty-restart
Open

Use Postgres state and explicit sync waits in the crash-recovery test#993
jmqd wants to merge 8 commits into
mainfrom
test/postgres-store-dirty-restart

Conversation

@jmqd

@jmqd jmqd commented Aug 24, 2026

Copy link
Copy Markdown
Contributor

This PR makes the randomized crash and restart test more realistic and reduces potential flakiness.

  • Stores replication progress in Postgres and reopens it after the simulated crash, rather than
    reusing in-memory state.
  • Waits for initial table synchronization before testing crashes, and for the table to be ready
    after restart before shutting down.
  • Clarifies that recording an event at the destination does not mean the pipeline has finished
    processing its response.

The test still checks that replication recovers without copying the table again. No production
behavior changes.

@coveralls

coveralls commented Aug 24, 2026

Copy link
Copy Markdown

Coverage Status

coverage: 76.549% (+0.004%) from 76.545% — test/postgres-store-dirty-restart into main

@jmqd
jmqd marked this pull request as ready for review August 25, 2026 17:41
@jmqd
jmqd enabled auto-merge (squash) August 26, 2026 17:07
@jmqd jmqd changed the title fix: Use postgres store for dirty restart test, wait for table sync dirty restart test: use postgres store, wait for table sync Aug 30, 2026
jmqd added 2 commits August 31, 2026 12:13
Keep PostgresStore polling for dirty-restart readiness and remove the superseded NotifyingStore helper from upstream.
@jmqd
jmqd requested a review from a team as a code owner September 5, 2026 19:37
@jmqd jmqd changed the title dirty restart test: use postgres store, wait for table sync Use Postgres state and explicit sync waits in the crash-recovery test Sep 6, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants