-
-
Notifications
You must be signed in to change notification settings - Fork 371
fix: connect backoff mechanism #1354
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from 6 commits
Commits
Show all changes
10 commits
Select commit
Hold shift + click to select a range
abe7ac0
fix testing
filipecabaco 772214a
fix: connect backoff mechanism
filipecabaco 44fa2b1
use RateCounter
filipecabaco 2df9787
pr review fixes
filipecabaco fb1cd34
change variable name to connect_throttle_limit
filipecabaco 1ca0e16
fix dialyzer
filipecabaco 09dfbef
chore: fix tenant controller tests where 403 is returned (#1355)
edgurgel e324c0b
fix dialyzer
filipecabaco 228e4d1
more test fixing
filipecabaco c02c23b
fix: fix promex plugin test to be relative instead of absolute
edgurgel File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,37 @@ | ||
defmodule Realtime.Tenants.Connect.Backoff do | ||
@moduledoc """ | ||
Applies backoff on process initialization. | ||
""" | ||
alias Realtime.RateCounter | ||
alias Realtime.GenCounter | ||
alias Realtime.Tenants | ||
@behaviour Realtime.Tenants.Connect.Piper | ||
|
||
@impl Realtime.Tenants.Connect.Piper | ||
def run(acc) do | ||
%{tenant_id: tenant_id} = acc | ||
connect_throttle_limit = Application.fetch_env!(:realtime, :connect_throttle_limit) | ||
|
||
with {:ok, counter} <- start_connects_per_second_counter(tenant_id), | ||
{:ok, %{avg: avg}} when avg < connect_throttle_limit <- RateCounter.get(counter) do | ||
GenCounter.add(counter) | ||
{:ok, acc} | ||
else | ||
_ -> {:error, :tenant_create_backoff} | ||
end | ||
end | ||
|
||
defp start_connects_per_second_counter(tenant_id) do | ||
id = Tenants.connection_attempts_per_second_key(tenant_id) | ||
GenCounter.new(id) | ||
filipecabaco marked this conversation as resolved.
Show resolved
Hide resolved
|
||
|
||
res = | ||
RateCounter.new(id, idle_shutdown: :infinity) | ||
|
||
case res do | ||
{:ok, _} -> {:ok, id} | ||
{:error, {:already_started, _}} -> {:ok, id} | ||
{:error, reason} -> {:error, reason} | ||
end | ||
end | ||
end |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,42 @@ | ||
defmodule Realtime.Tenants.Connect.BackoffTest do | ||
use Realtime.DataCase, async: true | ||
alias Realtime.Tenants.Connect.Backoff | ||
|
||
setup do | ||
tenant_id = random_string() | ||
acc = %{tenant_id: tenant_id} | ||
{:ok, acc: acc} | ||
end | ||
|
||
test "does not apply backoff for a given tenant if never called", %{acc: acc} do | ||
assert {:ok, acc} == Backoff.run(acc) | ||
end | ||
|
||
test "applies backoff if the user as called more than once during the configured space", %{acc: acc} do | ||
# emulate calls | ||
for _ <- 1..10 do | ||
Backoff.run(acc) | ||
end | ||
|
||
Process.sleep(1000) | ||
assert {:error, :tenant_create_backoff} = Backoff.run(acc) | ||
end | ||
|
||
test "resets backoff after the configured space", %{acc: acc} do | ||
# emulate calls | ||
for _ <- 1..10 do | ||
Backoff.run(acc) | ||
end | ||
|
||
Process.sleep(1000) | ||
|
||
# emulate block | ||
assert {:error, :tenant_create_backoff} = Backoff.run(acc) | ||
|
||
# wait for the timer to expire | ||
Process.sleep(2000) | ||
|
||
# check that the backoff has been reset | ||
assert {:ok, acc} == Backoff.run(acc) | ||
end | ||
end |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.