chore: remove hackney and httpoison dependencies #1390
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Skipped Deployment
|
filipecabaco
approved these changes
May 29, 2025
We don't seem to use them for anything
edgurgel
force-pushed
the
remove/httpoison-hackney
branch
from
17d8eb9 to
77e7944
Compare
Member
|
🎉 This PR is included in version 2.36.6 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce?
A new CVE was released for hackney and it would involve upgrading this library or adding a new advisory exclusion. But we don't seem to use it.
GHSA-9fm9-hp7p-53mf
We don't seem to use them for anything
What is the current behavior?
Having hackney and httpoison as dependencies.
What is the new behavior?
Not having them.
Additional context
I simply removed httpoison from listed dependencies. Called
mix deps.unlock --unusedand that's what I got from it.