fix: unassign db_conn from socket to prevent dead connections #1393
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Skipped Deployment
|
lib/realtime_web/channels/realtime_channel/broadcast_handler.ex
Outdated
Show resolved
Hide resolved
filipecabaco
force-pushed
the
fix/unassign-db-conn-from-socket
branch
from
4c3457f to
13c3705
Compare
lib/realtime_web/channels/realtime_channel/broadcast_handler.ex
Outdated
Show resolved
Hide resolved
filipecabaco
force-pushed
the
fix/unassign-db-conn-from-socket
branch
from
13c3705 to
fecfbfe
Compare
|
@edgurgel added the move from handlers to RealtimeChannel so we centralize those calls. For now we just have a "catch all" error and we can refine afterwards when we have a better understanding of what is actually the errors being caught I also did the test by brute force change the syn state which won't trigger the Connect module exit flows |
|
Sorry for the conflicts! But at least it should be pretty straightforward to fix those 🙏 |
filipecabaco
force-pushed
the
fix/unassign-db-conn-from-socket
branch
from
fecfbfe to
d75d521
Compare
| for _ <- 1..100, reduce: socket do | ||
| socket -> | ||
| assert {:reply, :ok, socket} = | ||
| assert {:reply, :ok, _} = |
There was a problem hiding this comment.
This is the issue! socket needed to be passed around to be reduced and kept the policies that were cached etc!
I've pushed a fix!
filipecabaco
force-pushed
the
fix/unassign-db-conn-from-socket
branch
from
ebb26a9 to
3b7dc88
Compare
filipecabaco
force-pushed
the
fix/unassign-db-conn-from-socket
branch
from
3b7dc88 to
3817f04
Compare
|
🎉 This PR is included in version 2.36.10 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
What kind of change does this PR introduce?
unassign db_conn from socket to prevent dead connections