fix: revert phoenix promex plugin change #1404
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It turned out that the opentelemetry setup didn't need the latest ranch We don't need this change as it's calculating active connections differently
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Skipped Deployment
|
filipecabaco
approved these changes
Jun 2, 2025
Member
|
🎉 This PR is included in version 2.36.7 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It turned out that the opentelemetry setup didn't need the latest ranch
We don't need this change as it's calculating active connections differently
What kind of change does this PR introduce?
Reverts the change made here
After looking at ranch's code the essential difference is between
allandactive:https://github.com/ninenines/ranch/blob/a692f44567034dacf5efcaa24a24183788594eb7/src/ranch.erl#L354-L355
activesupervisor process is different from what ranch considers anactiveconnection.What is the current behavior?
Active connections metrics is not the same
What is the new behavior?
Feel free to include screenshots if it includes visual changes.
Additional context
Once we upgrade cowboy + ranch we need to revisit this and understand the difference.