-
-
Notifications
You must be signed in to change notification settings - Fork 408
feat: filter postgres changes by action #1624
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
This comment has been minimized.
This comment has been minimized.
e4000c5 to
c3583e6
Compare
c3583e6 to
2baeee3
Compare
filipecabaco
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
did we already ship the walrus change?
| transaction(conn, fn conn -> | ||
| Enum.map(subscription_list, fn %{id: id, claims: claims, subscription_params: params = {schema, table, filters}} -> | ||
| case query(conn, sql, [publication, schema, table, id, claims, filters]) do | ||
| Enum.map(subscription_list, fn %{ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
later we should extract this to a function as this is a bit cluttered but not important now
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good point. Will refactor!
The walrus PR has been merged if that's the question 🤔 |
|
yes it was 😁 didn't remember if it did happen approving to unblock |
Follow-up from supabase/walrus#77
What kind of change does this PR introduce?
Filter postgres changes based on action