Encapsulate storage database transaction APIs#1115
Draft
mcollina wants to merge 4 commits into
Draft
Conversation
mcollina
force-pushed
the
encapsulate-database-transactions
branch
from
09db4fa to
21e9f6d
Compare
Coverage Report for CI Build 26156167379Coverage decreased (-0.006%) to 74.868%Details
Uncovered Changes
Coverage Regressions3 previously-covered lines in 1 file lost coverage.
Coverage Stats
💛 - Coveralls |
mcollina
changed the title
mcollina
commented
May 20, 2026
| const [destinationBucket] = await Promise.all([ | ||
| this.storage.db.asSuperUser().findBucketById(Bucket, 'file_size_limit'), | ||
| this.storage.db.asSuperUser().findBucketById(sourceBucketName, 'id'), | ||
| ]) |
Contributor
Author
There was a problem hiding this comment.
add a new method to do this in one go
mcollina
commented
May 20, 2026
| } | ||
| ) | ||
| .catch(reject) | ||
| this.holdLockTransaction(stopSignal, resolve).catch(reject) |
Contributor
Author
There was a problem hiding this comment.
possible blocker, need to verify the S3 locker
mcollina
commented
May 20, 2026
| return this.withTransaction(async (db) => { | ||
| await db.mustLockObject(bucketId, objectName, version) | ||
| }, transactionOptions) | ||
| } |
Contributor
Author
There was a problem hiding this comment.
this is incorrect, the lock is gone after the transaction completes
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
DatabaseinterfaceObjshapesValidation
npx biome check src/storage/database/adapter.ts src/storage/database/knex.ts src/storage/events/objects/object-admin-delete-all-before.ts src/storage/object.ts src/storage/protocols/s3/s3-handler.ts src/storage/protocols/tus/postgres-locker.ts src/storage/storage.ts src/storage/uploader.ts src/test/s3-protocol.test.tsnpm run build