ci: add multigres to migration idempotency check#1155
Draft
TylerHillery wants to merge 2 commits into
Draft
Conversation
TylerHillery
force-pushed
the
tyler/feat/add-multigres-to-migrations-idemp-check
branch
from
b519790 to
e4a4d08
Compare
Coverage Report for CI Build 27565453267Coverage decreased (-0.01%) to 78.12%Details
Uncovered ChangesNo uncovered changes found. Coverage Regressions1 previously-covered line in 1 file lost coverage.
Coverage Stats
💛 - Coveralls |
Member
|
FYI, multigres image that supports pg_dump isn't ready yet |
Contributor
Author
Sounds good I will leave this in draft until it's ready to test |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce?
Now that multigres supports pg dump we can include it in the migrations idempotency check
What is the current behavior?
Currently multigres step doesn't include this check because it did not support pg dump
What is the new behavior?
Now we have multigres also do the migration idempotency check. I have extract this step into it's own common action so we can reuse it across steps. This centralizes the logic in one spot.
Additional context