fix: stream upload to S3#905
Merged
Merged
Conversation
ferhatelmas
force-pushed
the
storage/improve-upload-performance
branch
3 times, most recently
from
cfb19de to
057f446
Compare
fenos
commented
Mar 13, 2026
TylerHillery
approved these changes
Mar 13, 2026
itslenny
reviewed
Mar 16, 2026
Signed-off-by: ferhat elmas <elmas.ferhat@gmail.com>
Signed-off-by: ferhat elmas <elmas.ferhat@gmail.com>
ferhatelmas
force-pushed
the
storage/improve-upload-performance
branch
from
057f446 to
a0125fb
Compare
itslenny
approved these changes
Mar 16, 2026
This was referenced Apr 1, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce?
Improvement
What is the current behavior?
Currently, we upload to S3 using the
Uploadclass form the@aws-sdk/lib-storage.This library seems to be buffering in memory each chunk before uploading them to S3, (that's because it needs to calculate the size of the stream)
What is the new behavior?
We do know the content length in most cases, so we can simply pipe the body into the
PutObjectmethod so that we stream it all at once