fix(supabase): relax db schema type constraints in createClient options#2476
Open
gourabsingha1 wants to merge 1 commit into
Open
fix(supabase): relax db schema type constraints in createClient options#2476gourabsingha1 wants to merge 1 commit into
gourabsingha1 wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes a bug (Issue #969) where TypeScript displays a type error when attempting to initialize a client with a custom database schema under
db.schema, unless the user explicitly passes the schema as the second generic parameter tocreateClient. Because of the lack of partial generic inference in TypeScript, when only the first generic parameter<Database>is supplied, the second generic parameter (SchemaName) defaults to'public', restricting the type of thedb.schemaoption to'public'. This PR relaxes theschemaoption type underdbtostringso that initialization compiles successfully, while preserving type-safety of database/schema queries.