Skip to content

chore(ci): consolidate node version references#2508

Open
kanadgupta wants to merge 6 commits into
masterfrom
kanad-2026-07-09/simplify-node-version-in-ci
Open

chore(ci): consolidate node version references#2508
kanadgupta wants to merge 6 commits into
masterfrom
kanad-2026-07-09/simplify-node-version-in-ci

Conversation

@kanadgupta

Copy link
Copy Markdown
Contributor

🔍 Description

Tiny refactor to make it so all of the GitHub Actions workflow files rely on .nvmrc as its single source of truth for the Node.js version to use.

What changed?

(see above)

Why was this change needed?

n/a

📸 Screenshots/Examples

🔄 Breaking changes

  • This PR contains no breaking changes

📋 Checklist

  • I have read the Contributing Guidelines
  • My PR title follows the conventional commit format: <type>(<scope>): <description>
  • I have run pnpm nx format to ensure consistent code formatting
  • I have added tests for new functionality (if applicable)
  • I have updated documentation (if applicable)

📝 Additional notes

@kanadgupta
kanadgupta requested review from a team as code owners July 10, 2026 02:20
@pkg-pr-new

pkg-pr-new Bot commented Jul 10, 2026

Copy link
Copy Markdown

Open in StackBlitz

@supabase/auth-js

npm i https://pkg.pr.new/@supabase/auth-js@2508

@supabase/functions-js

npm i https://pkg.pr.new/@supabase/functions-js@2508

@supabase/postgrest-js

npm i https://pkg.pr.new/@supabase/postgrest-js@2508

@supabase/realtime-js

npm i https://pkg.pr.new/@supabase/realtime-js@2508

@supabase/storage-js

npm i https://pkg.pr.new/@supabase/storage-js@2508

@supabase/supabase-js

npm i https://pkg.pr.new/@supabase/supabase-js@2508

commit: 1df6e60

@coveralls

coveralls commented Jul 10, 2026

Copy link
Copy Markdown

Coverage Status

coverage: 80.513% (+4.0%) from 76.505% — kanad-2026-07-09/simplify-node-version-in-ci into master

@mandarini mandarini left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a nice cleanup. But, I found one thing that needs to change before this can merge: deprecate-version.yml doesn't have a checkout step in its deprecate job (it only calls npm deprecate against the registry, so it never needed the repo checked out before). Now that the setup-node step there uses node-version-file: '.nvmrc', it needs to read that file from the workspace, and without a checkout step it won't be there. Could you add an actions/checkout step before setup-node in that job, same as the other workflows in this PR? Since this workflow is workflow_dispatch only, none of our CI checks would catch this, so it'd only show up the next time someone tries to deprecate a package.

Also, two workflows still hardcode node-version: '22' and got left out of this pass: docs.yml and preview-release.yml. Would you mind updating those too so we don't end up with a couple of stragglers to fix the next time the Node version changes?

@kanadgupta

Copy link
Copy Markdown
Contributor Author

@mandarini this is great feedback, thanks for catching these! I addressed your feedback in 9e86564 and 1df6e60.

@kanadgupta
kanadgupta requested a review from mandarini July 13, 2026 18:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants