chore(ci): consolidate node version references#2508
Conversation
@supabase/auth-js
@supabase/functions-js
@supabase/postgrest-js
@supabase/realtime-js
@supabase/storage-js
@supabase/supabase-js
commit: |
There was a problem hiding this comment.
This is a nice cleanup. But, I found one thing that needs to change before this can merge: deprecate-version.yml doesn't have a checkout step in its deprecate job (it only calls npm deprecate against the registry, so it never needed the repo checked out before). Now that the setup-node step there uses node-version-file: '.nvmrc', it needs to read that file from the workspace, and without a checkout step it won't be there. Could you add an actions/checkout step before setup-node in that job, same as the other workflows in this PR? Since this workflow is workflow_dispatch only, none of our CI checks would catch this, so it'd only show up the next time someone tries to deprecate a package.
Also, two workflows still hardcode node-version: '22' and got left out of this pass: docs.yml and preview-release.yml. Would you mind updating those too so we don't end up with a couple of stragglers to fix the next time the Node version changes?
|
@mandarini this is great feedback, thanks for catching these! I addressed your feedback in 9e86564 and 1df6e60. |
🔍 Description
Tiny refactor to make it so all of the GitHub Actions workflow files rely on
.nvmrcas its single source of truth for the Node.js version to use.What changed?
(see above)
Why was this change needed?
n/a
📸 Screenshots/Examples
🔄 Breaking changes
📋 Checklist
<type>(<scope>): <description>pnpm nx formatto ensure consistent code formatting📝 Additional notes