perf(postgrest): speed up JSON parsing by 22x using json.loads - #1571
Open
Samearth17 wants to merge 1 commit into
Open
perf(postgrest): speed up JSON parsing by 22x using json.loads#1571Samearth17 wants to merge 1 commit into
Samearth17 wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Resolves #1486 by replacing the slow
JSONAdapter.validate_jsoncall inbase_request_builder.pywith the standard libraryjson.loads.Context
The current
JSONAdapter(a PydanticTypeAdapterover theJSONtype alias) performs redundant runtime validation. Because standard JSON parsing already guarantees the output matches theUnion[None, bool, str, int, float, Sequence[JSON], Mapping[str, JSON]]schema, we can safely skip the Pydantic validation pass entirely.This matches the exact, proven pattern already used successfully by
SingleAPIResponse.from_http_request_responsein the exact same file.Benchmarks
As reported in #1486 and verified by community members:
This represents a ~22x speedup for large payloads, requires zero new dependencies, and maintains exact backward compatibility.
Changes
ValidationErrorfrom Pydantic imports as it is no longer used.JSONAdapterimport.APIResponse.from_http_request_responseto usejson.loads+JSONDecodeErrorfallback.