-
-
Notifications
You must be signed in to change notification settings - Fork 93
feat: add tenant ban/unban API endpoint #895
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
mentels
wants to merge
6
commits into
main
Choose a base branch
from
chore/add-api-for-banning-unbanningt-tenant
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+502
−24
Open
Changes from all commits
Commits
Show all changes
6 commits
Select commit
Hold shift + click to select a range
ea91d69
feat: add tenant ban/unban API endpoint
mentels ac5fec9
feat: add banned_until
mentels 10bc55b
chore: improve tests
mentels ef642e2
feat: respect banned_until expiry in tenant ban check
mentels 7b30da3
Merge branch 'main' into chore/add-api-for-banning-unbanningt-tenant
v0idpwn 8a15a9b
fixup! feat: respect banned_until expiry in tenant ban check
mentels File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,18 @@ | ||
| defmodule Supavisor.Errors.TenantBannedError do | ||
| @moduledoc """ | ||
| This error is returned when a client attempts to connect to a banned tenant. | ||
| """ | ||
|
|
||
| use Supavisor.Error, [:ban_reason, code: "EBANNED"] | ||
|
|
||
| @type t() :: %__MODULE__{ | ||
| ban_reason: binary() | nil, | ||
| code: binary() | ||
| } | ||
|
|
||
| @impl Supavisor.Error | ||
mentels marked this conversation as resolved.
Show resolved
Hide resolved
|
||
| def error_message(%{ban_reason: reason}), do: "tenant is banned: #{reason}" | ||
|
|
||
| @impl Supavisor.Error | ||
| def log_level(_), do: :warning | ||
| end | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
11 changes: 11 additions & 0 deletions
11
priv/repo/migrations/20260323000000_add_tenant_ban_fields.exs
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,11 @@ | ||
| defmodule Supavisor.Repo.Migrations.AddTenantBanFields do | ||
| use Ecto.Migration | ||
|
|
||
| def change do | ||
| alter table(:tenants, prefix: "_supavisor") do | ||
| add(:banned_at, :utc_datetime, null: true) | ||
| add(:ban_reason, :string, null: true) | ||
| add(:banned_until, :utc_datetime, null: true) | ||
| end | ||
| end | ||
| end |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.