feat(iceberg_fdw): [WRA-16] add schema evolution support#590
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Adds schema evolution support to iceberg_fdw by upgrading to iceberg-rs 0.8.0 and wiring schema resolution/pushdown/writer changes needed to correctly read evolved Iceberg tables (older rows returning NULL for newly-added optional columns), with accompanying docs and tests.
Changes:
- Upgrade
iceberg/ catalog crates (and Arrow/Parquet) to newer versions required for schema evolution tolerant reads. - Add schema selection by
schema_id(optional) and adjust predicate pushdown to operate on the resolved schema. - Extend test/seed data to validate evolved-schema reads and pushdown on newly-added columns.
Reviewed changes
Copilot reviewed 9 out of 10 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| wrappers/src/fdw/iceberg_fdw/writer.rs | Adapts to upstream location generator API change (partition key-aware signature). |
| wrappers/src/fdw/iceberg_fdw/pushdown.rs | Changes pushdown API to accept an explicit Schema, enabling evolution-aware predicate building. |
| wrappers/src/fdw/iceberg_fdw/mod.rs | Adds SchemaNotFound error variant for explicit schema_id resolution failures. |
| wrappers/src/fdw/iceberg_fdw/iceberg_fdw.rs | Implements schema_id resolution on scan, updates Arrow schema conversion, upgrades catalog construction, and adjusts writer pipeline for new iceberg-rs APIs. |
| wrappers/src/fdw/iceberg_fdw/tests.rs | Adds schema evolution integration assertions and validates default-schema behavior when schema_id is dropped. |
| wrappers/src/fdw/iceberg_fdw/README.md | Bumps FDW version and changelog entry. |
| wrappers/dockerfiles/s3/iceberg_seed.py | Seeds a schema-evolved Iceberg table used by integration tests. |
| wrappers/Cargo.toml | Upgrades iceberg/arrow/parquet dependencies to required versions. |
| docs/catalog/iceberg.md | Documents schema evolution support and removes the prior “unsupported” limitation. |
| Cargo.lock | Lockfile updates reflecting the dependency upgrades. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
imor
approved these changes
Mar 24, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce?
This PR is to add schema evolution support to the Iceberg FDW and upgrades iceberg-rs from 0.6.0 to 0.8.0.
What is the current behavior?
What is the new behavior?
Additional context
N/A